source: josm

fix #19437 - OpenBrowserAction: make warning threshold of browser windows configurable

Advanced preference key warn.open.maxbrowser

• Add irrigation=pivot to farmland preset (usage > 10k) and make crop optional (can change every year)
• Fix checks with value_on=*

• fix #19579 - Ignore generator:output:electricity and plant:output:electricity
• fix #19589 - Don't warn about duplicate housenumbers if one is tagged on a barrier=entrance or barrier=gate node
• fix #19604 - Warn if the value of alt_name is the same as of name (patch by Famlam)

see #15240 - Change a lot png icons to svg:

• misc/statusreport, ​https://commons.wikimedia.org/wiki/File:Format-justify-fill.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/edit, ​https://commons.wikimedia.org/wiki/File:Format-justify-fill.svg, modiefied + dialogs/mappaint/pencil, from The Tango Desktop Project, PD and CC0 licensed
• clock, ​https://ftp.acc.umu.se/pub/gnome/sources/gnome-icon-theme/2.20/gnome-icon-theme-2.20.0.tar.bz2 /clock, modified, from GNOME Project, GPL licensed
• wayflip, derived from dialogs/reorderlayers, PD and CC0 licensed
• cursor/modifier/rectangle_move, cursor/modifier/rectangle_plus, cursor/modifier/rectangle_plussmall, derived from rectangle and png icon, PD and CC0 licensed
• cursor/hand, ​https://freesvg.org/hand-cursor-vector-illustration, modified, PD and CC0 licensed
• importaudio, dialogs/notes/note_comment, ​https://commons.wikimedia.org/wiki/File:Internet-talk-error.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/notes/note_closed, dialogs/notes/note_new, dialogs/notes/note_open, cursor/modifier/create_note, mapmode/addnote, ​https://github.com/openstreetmap/openstreetmap-website/blob/master/app/assets/images/NoteMarker.svg, from openstreetmap-website, resized, GPL licensed
• note_search, derived from new dialogs/notes/note_open and dialogs/search, from GNOME Project, GPL licensed
• eye, dialogs/showhide, dialogs/layerlist/eye, dialogs/layerlist/eye-translucent, dialogs/layerlist/eye-off, dialogs/layerlist/visibility, misc/buttonhide, misc/buttonshow ​https://publicdomainvectors.org/en/free-clipart/Blue-eye-vector-drawing/72608.html, modified, PD and CC0 licensed
• dialogs/layerlist/offset, self created, PD and CC0 licensed
• misc/check_large, ​https://freesvg.org/1545571884, modified, +shadow from tango, PD and CC0 licensed
• misc/sticky, self created, PD and CC0 licensed
• addmarkers, dialogs/pin, layer/marker_small, ​https://publicdomainvectors.org/en/free-clipart/Pin-with-shadow/50158.html, modified, PD and CC0 licensed
• dialogs/sort, dialogs/sort_below, dialogs/reverse, ​https://ftp.acc.umu.se/pub/gnome/sources/gnome-icon-theme/2.20/gnome-icon-theme-2.20.0.tar.bz2 /view-sort, modified, from GNOME Project, GPL licensed
• dialogs/filter, ​https://freesvg.org/green-funnel, modified, PD and CC0 licensed
• dialogs/relation/roundedcorners, dialogs/relation/arrowup, dialogs/relation/arrowdown, self created, PD and CC0 licensed
• dialogs/geoimage/photo-marker, dialogs/geoimage/photo-marker-selected, self created, PD and CC0 licensed
• mapmode/playheaddrag, self created, derived from markers/audio-tracer, PD and CC0 licensed
• data/imagery/elevation, ​https://freesvg.org/1418161967, modified, PD and CC0 licensed
• expert, ​https://publicdomainvectors.org/en/free-clipart/Glowing-light-bulb/83473.html, modified, PD and CC0 licensed
• dialogs/select, self created, derived from png and old cursor/normal, PD and CC0 licensed
• dialogs/addrelation, derived from data/relation and dialogs/add, PD and CC0 licensed
• dialogs/history, self created + shadow from Tango, PD and CC0 licensed
• dialogs/add, pastetags, self created, derived from png, PD and CC0 licensed
• dialogs/fix, ​https://ftp.acc.umu.se/pub/gnome/sources/gnome-icon-theme/2.91/gnome-icon-theme-2.91.93.tar.bz2 /preferences-system, modified, from GNOME Project, GPL licensed
• dialogs/autoscale/conflict, derived from png and dialogs/conflict, PD and CC0 licensed
• dialogs/autoscale/data, derived from png and dialogs/search, from GNOME Project, LGPL licensed
• dialogs/autoscale/layer, derived from png and dialogs/layerlist, PD and CC0 licensed
• dialogs/autoscale/next, derived from png and redo, PD and CC0 licensed
• dialogs/autoscale/previous, derived from png and undo, PD and CC0 licensed
• dialogs/autoscale/problem, derived from png and data/warning, PD and CC0 licensed
• dialogs/autoscale/selection, derived from png and dialogs/select, PD and CC0 licensed
• zoomin and zoomout, self created, derived from png, PD and CC0 licensed
• colorchooser, self created, PD and CC0 licensed
• improve some icons
• use save instead of save_as icon in "File exists. Overwrite?" dialog because after you hit the button you can't edit the name anymore and no new file is created.

fix #19400 - Remote control: generate OpenAPI specification

fix #19248 - Allow to toggle offline mode in the file menu ("Work Offline...")

Java 8: use Map.getOrDefault

• remove TLD from IANA
• ignore mofa=use_sidepath and moped=use_sidepath

RenderingCLI: default to elemstyles.mapcss

RenderingCLI: handle NoSuchFileException

Fix typo in Javadoc

I18n update

I18n update

see #15240 - Change some png icons to svg:

• mapmode/rope, ​https://github.com/GNOME/gimp/blob/master/icons/Color/24/gimp-tool-free-select.svg, from GNOME Project, GPL licensed
• cursor/modifier/rope, ​https://github.com/GNOME/gimp/blob/master/icons/Color/24/gimp-tool-free-select.svg, resized, from GNOME Project, GPL licensed
• dialogs/commandstack, derived from undo and redo, from GNOME Project, LGPL licensed
• dialogs/minimap, derived from data/imagery/map, PD and CC0 licensed
• dialogs/relationlist, derived from data/relation, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/userlist, derived from data/user, from The Tango Desktop Project, PD and CC0 licensed
• remove dialogs/moveup and dialogs/movedown, use dialogs/up and dialogs/down instead
• remove dialogs/uploadproperties, use preference instead
• improve a few icons

fix #19571 - Update to OpeningHoursParser 0.22.0

see #17750 - Remove controversial bicycle=dismount

• fix #17750 - Add more access tags to barrier presets including icons for checks (new plain icons from ​https://commons.wikimedia.org/wiki/Category:Symbols_of_road_signs_of_Germany, all PD and CC0 licensed, patch by skyper)
• add icon for barrier=bus_trap (from ​https://wiki.openstreetmap.org/wiki/File:Barrier_bus_trap.svg, modified, PD and CC0 licensed)
• unify red color of traffic signs

see #15240 - Change some png icons to svg:

• data/relation ​https://commons.wikimedia.org/wiki/File:Emblem-system.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/mappaint/pencil ​https://commons.wikimedia.org/wiki/File:Text-x-generic_with_pencil.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• dialogs/search ​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg, modified, from GNOME Project, LGPL licensed
• dialogs/zoom-best-fit ​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg, modified, from GNOME Project, LGPL licensed
• mapmode/zoom ​https://commons.wikimedia.org/wiki/File:Gnome-zoom-fit-best.svg, modified, from GNOME Project, LGPL licensed
• info ​https://commons.wikimedia.org/wiki/File:Emblem-notice.svg, from The Tango Desktop Project, PD and CC0 licensed
• java ​https://en.wikipedia.org/wiki/Java_(programming_language)#/media/File:Java_programming_language_logo.svg, modified, without license, fair use
• remove dialogs/settings, use preference instead

see #15240 - Change some png icons to svg:

• dialogs/refresh ​https://commons.wikimedia.org/wiki/File:View-refresh.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• preferences/advanced ​https://commons.wikimedia.org/wiki/File:Gnome-document-properties.svg, from GNOME Project, LGPL licensed
• preferences/display ​https://commons.wikimedia.org/wiki/File:Gnome-preferences-desktop-wallpaper.svg, from GNOME Project, LGPL licensed
• preferences/reset ​https://commons.wikimedia.org/wiki/File:Edit-undo.svg, from The Tango Desktop Project, PD and CC0 licensed
• preferences/shortcuts ​https://commons.wikimedia.org/wiki/File:Preferences-desktop-keyboard-shortcuts.svg, from The Tango Desktop Project, PD and CC0 licensed
• view-fullscreen ​https://commons.wikimedia.org/wiki/File:View-fullscreen.svg, resized, from The Tango Desktop Project, PD and CC0 licensed
• view-fullscreen-revert ​https://commons.wikimedia.org/wiki/File:View-fullscreen.svg, modified, from The Tango Desktop Project, PD and CC0 licensed
• warning-small derived from internal data/warning icon, PD and CC0 licensed

remove TLD from IANA

see #19312: detect circular dependencies in relations

• implement preference key validator.relation.allow.complex.dependency to disable warnings from validator or relation editor when multiple relations generate a dependency loop

fix #19425 - AddTagsDialog: fix handling of trustedSenders

fix #19514 - IllegalStateException if double clicking with CTRL on items in the Command Stack Dialog

see #19180

• deprecate generator:type=solar_photovoltaic_panels and building=part
• ignore building=home, building=tank, water=pool, historic=farm
• add resource=clay

• adjust fixme icons to avoid possible rendering artifacts

see #19370, see #18319 - native/macosx/JOSM.app/Contents/Resources/JOSM.icns (used by Ant)

fix #19544 - Warn about building overlapping with building:part and revert r16779 (overlapping building:part)

fix #19432: Split way: AIOOB: Problem with member check with duplicate members

• don't store position of member, instead always search it
• improve calculation of missing(incomplete) way members and store the result instead of calculating it twice
• add unit test

see #16707 - Warn about overlapping building:part too

fix #17296 - support variant FIXME too

fix #17296 - If the value of fixme is also a tag, ask if the fixme is fixed (patch by taylor.smock, modified)

fix #19444 - Update tag2link

fix #19508 - better reversal function for number, patch by gaben

fix #10932 - Warn about ways with *:lanes but without lanes (also with :forward, :backward and :both_ways extensions) (patch by skyper, modified)

fix #19436 - RequestProcessor: do not add null objects to a JsonArray (patch by taylor.smock, modified)

see #16567 - Fix DomainValidatorTestIT for JUnit 5 (patch by taylor.smock)

see #19180 - fix typos in ignorelist, remove police=yes from ignorelist (has warning but is also in presets for an unknown police facility), remove deprecated vending=photos from presets

see #19526: Multipolygon validation failures

• find shared segments with outer ways when multipolygon relation is incomplete. Relies on the roles of the complete way members, an empty role is considered to be "outer".

see #19515, see #10759 - Little reorder in the preset menu, new man_made subgroup Towers

move Outdoor seating preset in food group as it is similar to Food Court and Beer Garden

• see #19517 - Add club=* (icon derived from internal office=association icon, PD and CC0 licensed)
• Add sport=chess preset (mappaint style was already there)

see #9164 - fix icon display

see #19445 - fix icon path

see #18698 - remove new tags from ignore list

fix #19445 - Add man_made=telescope (icons from ​https://wiki.openstreetmap.org/wiki/File:Telescope_dish-14.svg and ​https://wiki.openstreetmap.org/wiki/File:Telescope_dome-14.svg, PD and CC0 licensed)

fix #11245 - add clothes=* to shop=clothes preset

fix #18698 - split Road Restrictions preset in Road Restrictions and Access Restrictions

• fix #19440 - Add placement:forward/backward to highway presets
• fix #16391 - Add noref=yes and noname=yes checkboxes after ref and name fields in highway presets
• save some space in height of preset window by reordering checks a bit
• based on patch by skyper

see #19483 - typo

disable broken tests (service broken)

fix #19483 - don't support undocumented behaviour