source: josm

see #16805 - add 64x64 logo

see #16820 - extract GUI from UnglueAction

see #16047 - update to JMockit 1.43 (contains Java11 fix)

see ​https://github.com/jmockit/jmockit1/issues/534

rework Travis config:

• add Windows build (Oracle JDK 11 only as Java is not fully supported yet)
• drop openjdk10 (not LTS)
• use openjdk11 on Linux instead of oraclejdk11
• add macOS xcode10 (ships with jdk10)

fix #16834 - IAE when opening .osmc containing empty note created by OsmAnd

see #16819 - Travis: display output of failed tests only to avoid exceeding the maximum log length

fix #16825 - fix small typo (patch by naoliv)

see #16819 - should fix KeyboardUtilsTest on macOS

fix #16816 - new option to show object version in lists, similar to object ID

fix #16814 - IOOBE

see #16781 - fix more typos using ​https://github.com/vlajos/misspell-fixer

fix #16809 - SlippyMapBBoxChooser: include tile sources from current layers (patch by ris, modified)

update TLD from IANA

fix #16806 - include class name in error message

fix indent really

handle https/http for icons as well

fix #16797 - NPE

fix unit test / checkstyle

fix unit test (for good)

fix #16778 - cache padded icons to improve performance when filtering relations

see #16732 - more keyboard fixes

presets lang update

i18n update

fix #16785 - fix IOOBE

fix bug when writing a locked OSM layer

HTTPS enabled for {cr,hg,mail}.openjdk.java.net, see ​http://mail.openjdk.java.net/pipermail/announce/2018-September/000256.html

Treat SocketTimeoutException as transient error.

Extend CacheEntryAttributes and allow storage of exception class name. Use this
information to treat SocketTimeoutException in TMS downloads as transient.

See: #16743

Retry tile download on transient errors.

Till now there was no strategy to retry tile download. Tiles for which download
finished with error where by design not downloaded again. Because we were
issuing surplus download requests it was not easy to notice, that some tiles
where downloaded at different zoom level. When surplus downloads where removed -
problem became aparent.

Redefine semantics in AbstractTileSourceLayer, that all Tiles that are not
loaded are tried again. Move all logic deciding whether tile has loaded or not
to TMSCachedTileLoaderJob.

Implment in TMSCachedTileLoaderJob following rules:

• when HTTP status code is between 400 and 500 - treat errors as permament
• when HTTP status code equals or is greater than 500 - then treat error as

temporary

• when there was exception in JCSCachedTileLoaderJob, then HTTP status code is

set to 599. Treat this as permament error. This is suboptimal, as we could treat
Socket read timeout and similar as temporary, and UnkownHostException as
permament

The other aproach is to implement retry count in Tile and retry for finite
number of times, preferably with some delay between tries.

Closes: #16747
See: #16743

fix #16762 - support multiple notes in .osc files created by OsmAnd

fix #16757 - don't sort values of visibility in clock preset

Fix WMS simultaneus connections

When creating download thread pool set the maximum downloads per host to the
same value as simultaneus connections.

See: #16734

Fix unnecessary tile downloads.

Only download tiles from upper levels when we finished downloading all tiles in
currentZoomLevel.

Closes: #16747
See: #14562

see #16047 - disable Proguard on Java11+

see #15229 - move corrector package to actions.corrector

see #15229 - update spotbugs filters

one file missed

see #16730 - one file missed

fix #16730 - make sure we try to display popup menus only if their parent is visible on screen

fix #16406 - Update government types in office=government preset (patch by naoliv)

see #11924, see #15560, see #16047, see #16682 - fixes to make work proguard (OK) and animal_sniffer (still KO) with Java 9+

see #16047, see #16682 - update animal-sniffer-ant-tasks to 1.18-SNAPSHOT + patches to include ASM 6.2.1 for Java 11 compatibility:

• base revision: 59bee73c4577dc9aafd5774fe62070f00dceacee
• patch 1: ​https://github.com/mojohaus/animal-sniffer/pull/58
• patch 2: ​https://github.com/mojohaus/animal-sniffer/pull/59

fix #16708 - add narrow=yes to highway presets

fix #16510 - improve performance of Ctrl-A by caching icons used to display OSM primitive types

update checkstyle configuration

see #16047, see #16682 - make PluginClassLoader extend DynamicURLClassLoader so that plugins can add URLs to it

see #16047 - make JOSM able to load JAXB as a plugin:

• JAXB initialize itself through ServiceLoader and context class loader so it must be set correctly when initializing a plugin
• plugin class loaders were not loading resources correctly

see #13108 - macOS: register .joz file type handler (patch by accek, see ​https://github.com/openstreetmap/josm/pull/26)

fix #16721 - add shoes:repair=yes|no to shop=shoe preset
fix #16722 - add self_service=yes|no and laundry_service=yes|no to shop=laundry preset

see #16498 - fix NPE in error_prone

See ​https://github.com/google/error-prone/pull/1111
See ​https://github.com/google/error-prone/issues/1106#issuecomment-418871026

see #16498 - update shaded error_prone_core.jar to include all required dependencies