Changeset 9990 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2016-03-14T01:58:27+01:00 (8 years ago)

Author:

Don-vip

Message:

sonar - Inner classes which do not reference their owning classes should be static

Location:

trunk/src/org/openstreetmap/josm

Files:

• gui/conflict/pair/ListMerger.java (modified) (1 diff)
• gui/preferences/projection/ListProjectionChoice.java (modified) (1 diff)
• io/OsmServerLocationReader.java (modified) (1 diff)
• io/remotecontrol/handler/LoadDataHandler.java (modified) (1 diff)
• tools/template_engine/ContextSwitchTemplate.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/conflict/pair/ListMerger.java

@@ -416 +416 @@
      * Base class of all other Copy* inner classes.
      */
-    abstract class CopyAction extends AbstractAction implements ListSelectionListener {
+    abstract static class CopyAction extends AbstractAction implements ListSelectionListener {
 
         protected CopyAction(String icon_name, String action_name, String short_description) {

trunk/src/org/openstreetmap/josm/gui/preferences/projection/ListProjectionChoice.java

@@ -85 +85 @@
     }
 
-    protected class CBPanel extends JPanel {
+    protected static class CBPanel extends JPanel {
         public JosmComboBox<String> prefcb;
 

trunk/src/org/openstreetmap/josm/io/OsmServerLocationReader.java

@@ -33 +33 @@
     }
 
-    protected abstract class Parser<T> {
+    protected abstract static class Parser<T> {
         protected final ProgressMonitor progressMonitor;
         protected final Compression compression;

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/LoadDataHandler.java

@@ -97 +97 @@
     }
 
-    protected class LoadDataTask extends DownloadOsmTask.AbstractInternalTask {
+    protected static class LoadDataTask extends DownloadOsmTask.AbstractInternalTask {
 
         protected final String layerName;

trunk/src/org/openstreetmap/josm/tools/template_engine/ContextSwitchTemplate.java

@@ -40 +40 @@
     };
 
-    private abstract class ContextProvider extends Match {
+    private abstract static class ContextProvider extends Match {
         protected Match condition;