Changeset 9989 in josm


Ignore:
Timestamp:
2016-03-14T01:49:27+01:00 (4 years ago)
Author:
Don-vip
Message:

sonar - Methods should not be empty

Location:
trunk/src/org/openstreetmap/josm
Files:
16 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/Main.java

    r9821 r9989  
    678678                        @Override
    679679                        public void flush() {
     680                            // Do nothing
    680681                        }
    681682
    682683                        @Override
    683684                        public void close() {
     685                            // Do nothing
    684686                        }
    685687                    });
     
    12641266    }
    12651267
    1266     private static class WindowPositionSizeListener extends WindowAdapter implements
    1267     ComponentListener {
     1268    private static class WindowPositionSizeListener extends WindowAdapter implements ComponentListener {
    12681269        @Override
    12691270        public void windowStateChanged(WindowEvent e) {
     
    12731274        @Override
    12741275        public void componentHidden(ComponentEvent e) {
     1276            // Do nothing
    12751277        }
    12761278
     
    12871289        @Override
    12881290        public void componentShown(ComponentEvent e) {
     1291            // Do nothing
    12891292        }
    12901293
  • trunk/src/org/openstreetmap/josm/actions/UpdateModifiedAction.java

    r7434 r9989  
    3434
    3535    // FIXME: overrides the behaviour of UpdateSelectionAction. Doesn't update
    36     // the enabled state based on the current selection because
    37     // it doesn't depend on it.
     36    // the enabled state based on the current selection because it doesn't depend on it.
    3837    // The action should be enabled/disabled based on whether there is a least
    3938    // one modified object in the current dataset. Unfortunately, there is no
     
    5150    @Override
    5251    protected void updateEnabledState(Collection<? extends OsmPrimitive> selection) {
     52        // Do nothing
    5353    }
    5454
  • trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadOsmChangeTask.java

    r8510 r9989  
    212212        @Override
    213213        public void historyDataSetCleared(HistoryDataSet source) {
     214            // Do nothing
    214215        }
    215216    }
  • trunk/src/org/openstreetmap/josm/actions/mapmode/AddNoteAction.java

    r9944 r9989  
    9494    @Override
    9595    public void doKeyReleased(KeyEvent e) {
     96        // Do nothing
    9697    }
    9798}
  • trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java

    r9623 r9989  
    350350    @Override
    351351    public void doKeyPressed(KeyEvent e) {
     352        // Do nothing
    352353    }
    353354
  • trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

    r9970 r9989  
    667667    @Override
    668668    public void doKeyReleased(KeyEvent e) {
     669        // Do nothing
    669670    }
    670671
  • trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

    r9980 r9989  
    653653
    654654    public static class SearchSetting {
    655         public String text = "";
    656         public SearchMode mode = SearchMode.replace;
     655        public String text;
     656        public SearchMode mode;
    657657        public boolean caseSensitive;
    658658        public boolean regexSearch;
     
    664664         */
    665665        public SearchSetting() {
     666            text = "";
     667            mode = SearchMode.replace;
    666668        }
    667669
  • trunk/src/org/openstreetmap/josm/command/DeleteCommand.java

    r9971 r9989  
    154154
    155155    @Override
    156     public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted,
    157             Collection<OsmPrimitive> added) {
     156    public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted, Collection<OsmPrimitive> added) {
     157        // Do nothing
    158158    }
    159159
  • trunk/src/org/openstreetmap/josm/command/PurgeCommand.java

    r9371 r9989  
    276276    @Override
    277277    public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted, Collection<OsmPrimitive> added) {
     278        // Do nothing
    278279    }
    279280
  • trunk/src/org/openstreetmap/josm/command/SelectCommand.java

    r9371 r9989  
    3333    @Override
    3434    public void fillModifiedData(Collection<OsmPrimitive> modified, Collection<OsmPrimitive> deleted, Collection<OsmPrimitive> added) {
     35        // Do nothing
    3536    }
    3637
  • trunk/src/org/openstreetmap/josm/data/gpx/Extensions.java

    r8308 r9989  
    33
    44import java.util.LinkedHashMap;
    5 import java.util.Map;
    65
    76/**
     
    1211    private static final long serialVersionUID = 1L;
    1312
    14     public Extensions(Map<? extends String, ? extends String> m) {
    15         super(m);
    16     }
    17 
     13    /**
     14     * Constructs a new {@code Extensions}.
     15     */
    1816    public Extensions() {
     17        super();
    1918    }
    2019}
  • trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

    r9978 r9989  
    232232         */
    233233        public ImageryPreferenceEntry() {
     234            // Do nothing
    234235        }
    235236
     
    296297            valid_georeference = i.isGeoreferenceValid();
    297298            supports_epsg_4326_to_3857_conversion = i.isEpsg4326To3857Supported();
    298 
    299299        }
    300300
  • trunk/src/org/openstreetmap/josm/data/osm/Node.java

    r9979 r9989  
    319319    @Override
    320320    public void updatePosition() {
     321        // Do nothing
    321322    }
    322323
  • trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

    r9933 r9989  
    344344    @Override
    345345    public void activeLayerChange(Layer oldLayer, Layer newLayer) {
     346        // Do nothing
    346347    }
    347348
    348349    @Override
    349350    public void layerAdded(Layer newLayer) {
     351        // Do nothing
    350352    }
    351353
  • trunk/src/org/openstreetmap/josm/data/validation/Test.java

    r9397 r9989  
    227227
    228228    @Override
    229     public void visit(Node n) {}
    230 
    231     @Override
    232     public void visit(Way w) {}
    233 
    234     @Override
    235     public void visit(Relation r) {}
     229    public void visit(Node n) {
     230        // To be overridden in subclasses
     231    }
     232
     233    @Override
     234    public void visit(Way w) {
     235        // To be overridden in subclasses
     236    }
     237
     238    @Override
     239    public void visit(Relation r) {
     240        // To be overridden in subclasses
     241    }
    236242
    237243    /**
  • trunk/src/org/openstreetmap/josm/data/validation/TestError.java

    r8958 r9989  
    366366    }
    367367
    368     @Override public void primitivesAdded(PrimitivesAddedEvent event) {}
    369 
    370     @Override public void tagsChanged(TagsChangedEvent event) {}
    371 
    372     @Override public void nodeMoved(NodeMovedEvent event) {}
    373 
    374     @Override public void wayNodesChanged(WayNodesChangedEvent event) {}
    375 
    376     @Override public void relationMembersChanged(RelationMembersChangedEvent event) {}
    377 
    378     @Override public void otherDatasetChange(AbstractDatasetChangedEvent event) {}
    379 
    380     @Override public void dataChanged(DataChangedEvent event) {}
     368    @Override public void primitivesAdded(PrimitivesAddedEvent event) {
     369        // Do nothing
     370    }
     371
     372    @Override public void tagsChanged(TagsChangedEvent event) {
     373        // Do nothing
     374    }
     375
     376    @Override public void nodeMoved(NodeMovedEvent event) {
     377        // Do nothing
     378    }
     379
     380    @Override public void wayNodesChanged(WayNodesChangedEvent event) {
     381        // Do nothing
     382    }
     383
     384    @Override public void relationMembersChanged(RelationMembersChangedEvent event) {
     385        // Do nothing
     386    }
     387
     388    @Override public void otherDatasetChange(AbstractDatasetChangedEvent event) {
     389        // Do nothing
     390    }
     391
     392    @Override public void dataChanged(DataChangedEvent event) {
     393        // Do nothing
     394    }
    381395
    382396    @Override
Note: See TracChangeset for help on using the changeset viewer.