Changeset 9732 in josm for trunk/src/org/openstreetmap/josm/io/remotecontrol

Timestamp:

2016-02-04T00:48:38+01:00 (8 years ago)

Author:

Don-vip

Message:

remote control: add more unit tests, robustness

Location:

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler

Files:

• AddNodeHandler.java (modified) (1 diff)
• ImportHandler.java (modified) (1 diff)
• RequestHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/AddNodeHandler.java

@@ -115 +115 @@
     protected void validateRequest() throws RequestHandlerBadRequestException {
         try {
-            lat = Double.parseDouble(args.get("lat"));
-            lon = Double.parseDouble(args.get("lon"));
+            lat = Double.parseDouble(args != null ? args.get("lat") : "");
+            lon = Double.parseDouble(args != null ? args.get("lon") : "");
         } catch (NumberFormatException e) {
             throw new RequestHandlerBadRequestException("NumberFormatException ("+e.getMessage()+')', e);

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/ImportHandler.java

@@ -98 +98 @@
     @Override
     protected void validateRequest() throws RequestHandlerBadRequestException {
-        String urlString = args.get("url");
+        String urlString = args != null ? args.get("url") : null;
         if (Main.pref.getBoolean("remotecontrol.importhandler.fix_url_query", true)) {
             urlString = Utils.fixURLQuery(urlString);

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandler.java

@@ -223 +223 @@
         List<String> missingKeys = new LinkedList<>();
         boolean error = false;
-        if (mandatory != null) for (String key : mandatory) {
-            String value = args.get(key);
-            if (value == null || value.isEmpty()) {
-                error = true;
-                Main.warn('\'' + myCommand + "' remote control request must have '" + key + "' parameter");
-                missingKeys.add(key);
+        if (mandatory != null && args != null) {
+            for (String key : mandatory) {
+                String value = args.get(key);
+                if (value == null || value.isEmpty()) {
+                    error = true;
+                    Main.warn('\'' + myCommand + "' remote control request must have '" + key + "' parameter");
+                    missingKeys.add(key);
+                }
             }
         }
         Set<String> knownParams = new HashSet<>();
-        if (mandatory != null) Collections.addAll(knownParams, mandatory);
-        if (optional != null) Collections.addAll(knownParams, optional);
-        for (String par: args.keySet()) {
-            if (!knownParams.contains(par)) {
-                Main.warn("Unknown remote control parameter {0}, skipping it", par);
+        if (mandatory != null)
+            Collections.addAll(knownParams, mandatory);
+        if (optional != null)
+            Collections.addAll(knownParams, optional);
+        if (args != null) {
+            for (String par: args.keySet()) {
+                if (!knownParams.contains(par)) {
+                    Main.warn("Unknown remote control parameter {0}, skipping it", par);
+                }
             }
         }