Changeset 9407 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2016-01-11T03:31:44+01:00 (8 years ago)

Author:

Don-vip

Message:

findbugs - fix warning OBL_UNSATISFIED_OBLIGATION: "Version.init() may fail to clean up java.io.InputStream" by using try-with-resources

File:

• trunk/src/org/openstreetmap/josm/data/Version.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/Version.java

@@ -58 +58 @@
         try {
             properties.load(revisionInfo);
-            revisionInfo.close();
         } catch (IOException e) {
             Main.warn(tr("Error reading revision info from revision file: {0}", e.getMessage()));
@@ -111 +110 @@
      */
     public void init() {
-        InputStream stream = Main.class.getResourceAsStream("/REVISION");
-        if (stream == null) {
-            Main.warn(tr("The revision file ''/REVISION'' is missing."));
-            version = 0;
-            releaseDescription = "";
-            return;
-        }
-        initFromRevisionInfo(stream);
+        try (InputStream stream = Main.class.getResourceAsStream("/REVISION")) {
+            if (stream == null) {
+                Main.warn(tr("The revision file ''/REVISION'' is missing."));
+                version = 0;
+                releaseDescription = "";
+                return;
+            }
+            initFromRevisionInfo(stream);
+        } catch (IOException e) {
+            Main.warn(e);
+        }
     }