Index: trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/JoinAreasAction.java (revision 8931) @@ -259,5 +259,6 @@ /** - * Oriented angle (N1N2, N1N3) in range [0; 2*Math.PI[ + * Returns oriented angle (N1N2, N1N3) in range [0; 2*Math.PI[ + * @return oriented angle (N1N2, N1N3) in range [0; 2*Math.PI[ */ private static double getAngle(Node N1, Node N2, Node N3) { @@ -588,9 +589,8 @@ // Find boundary ways List discardedWays = new ArrayList<>(); - List bounadries = findBoundaryPolygons(preparedWays, discardedWays); + List boundaries = findBoundaryPolygons(preparedWays, discardedWays); //find polygons - List preparedPolygons = findPolygons(bounadries); - + List preparedPolygons = findPolygons(boundaries); //assemble final polygons Index: trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/OrthogonalizeAction.java (revision 8931) @@ -199,4 +199,5 @@ /** * Collect groups of ways with common nodes in order to orthogonalize each group separately. + * @return groups of ways with common nodes */ private static List> buildGroups(List wayDataList) { @@ -245,4 +246,5 @@ * - The same for vertical segments. * 5. Rotate back. + * @return list of commands to perform * @throws InvalidUserInputException if selected ways have an angle different from 90 or 180 degrees **/ @@ -475,4 +477,5 @@ /** * Make sure angle (up to 2*Pi) is in interval [ 0, 2*Pi ). + * @return correct angle */ private static double standard_angle_0_to_2PI(double a) { @@ -488,4 +491,5 @@ /** * Make sure angle (up to 2*Pi) is in interval ( -Pi, Pi ]. + * @return correct angle */ private static double standard_angle_mPI_to_PI(double a) { @@ -509,4 +513,5 @@ /** * Rotate counter-clock-wise. + * @return new east/north */ public static EastNorth rotateCC(EastNorth pivot, EastNorth en, double angle) { @@ -535,5 +540,6 @@ /** * Recognize angle to be approximately 0, 90, 180 or 270 degrees. - * returns an integral value, corresponding to a counter clockwise turn: + * returns an integral value, corresponding to a counter clockwise turn. + * @return an integral value, corresponding to a counter clockwise turn * @throws RejectedAngleException in case of invalid angle */ Index: trunk/src/org/openstreetmap/josm/actions/PasteTagsAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/PasteTagsAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/PasteTagsAction.java (revision 8931) @@ -64,6 +64,7 @@ /** - * Replies true if the source for tag pasting is heterogeneous, i.e. if it doesn't consist of + * Determines if the source for tag pasting is heterogeneous, i.e. if it doesn't consist of * {@link OsmPrimitive}s of exactly one type + * @return true if the source for tag pasting is heterogeneous */ protected boolean isHeteogeneousSource() { Index: trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/SplitWayAction.java (revision 8931) @@ -67,6 +67,6 @@ private final Command command; private final List newSelection; - private Way originalWay; - private List newWays; + private final Way originalWay; + private final List newWays; /** Index: trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/UnGlueAction.java (revision 8931) @@ -225,4 +225,5 @@ * The way will be put into the object variable "selectedWay", the * node into "selectedNode". + * @return true if either one node is selected or one node and one way are selected and the node is part of the way */ private boolean checkSelection(Collection selection) { @@ -260,4 +261,5 @@ * The way will be put into the object variable "selectedWay", the * nodes into "selectedNodes". + * @return true if one way and any number of nodes that are part of that way are selected */ private boolean checkSelection2(Collection selection) { @@ -302,4 +304,5 @@ *
  • the changed way will be returned and must be put into cmds by the caller!
    • * + * @return new way */ private static Way modifyWay(Node originalNode, Way w, List cmds, List newNodes) { Index: trunk/src/org/openstreetmap/josm/actions/UploadAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/UploadAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/UploadAction.java (revision 8931) @@ -163,6 +163,7 @@ /** - * returns true if the user wants to cancel, false if they - * want to continue + * Warn user about discouraged upload, propose to cancel operation. + * @param layer incriminated layer + * @return true if the user wants to cancel, false if they want to continue */ public static boolean warnUploadDiscouraged(AbstractModifiableLayer layer) { Index: trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/mapmode/DrawAction.java (revision 8931) @@ -155,5 +155,6 @@ /** - * Checks if a map redraw is required and does so if needed. Also updates the status bar + * Checks if a map redraw is required and does so if needed. Also updates the status bar. + * @return true if a repaint is needed */ private boolean redrawIfRequired() { @@ -1103,5 +1104,5 @@ /** * Removes target highlighting from primitives. Issues repaint if required. - * Returns true if a repaint has been issued. + * @return true if a repaint has been issued. */ private boolean removeHighlighting() { @@ -1235,4 +1236,5 @@ * to work around this issue. * Otherwise the normal selection of the current data layer is returned. + * @return selected primitives, while draw action is in progress */ public Collection getInProgressSelection() { Index: trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/mapmode/ExtrudeAction.java (revision 8931) @@ -1108,5 +1108,6 @@ /** - * Returns true if from1-to1 and from2-to2 vertors directions are opposite + * Determines if from1-to1 and from2-to2 vertors directions are opposite + * @return true if from1-to1 and from2-to2 vertors directions are opposite */ private static boolean isOppositeDirection(EastNorth from1, EastNorth to1, EastNorth from2, EastNorth to2) { Index: trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java (revision 8931) @@ -686,7 +686,8 @@ } - /** returns true whenever elements have been grabbed and moved (i.e. the initial - * thresholds have been exceeded) and is still in progress (i.e. mouse button - * still pressed) + /** + * Determines whenever elements have been grabbed and moved (i.e. the initial + * thresholds have been exceeded) and is still in progress (i.e. mouse button still pressed) + * @return true if a drag is in progress */ private boolean dragInProgress() { @@ -797,4 +798,5 @@ /** * Obtain command in undoRedo stack to "continue" when dragging + * @return last command */ private static Command getLastCommand() { @@ -901,4 +903,5 @@ * Tries to find a node to merge to when in move-merge mode for the current mouse * position. Either returns the node or null, if no suitable one is nearby. + * @return node to merge to, or null */ private Node findNodeToMergeTo(Point p) { Index: trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/search/SearchCompiler.java (revision 8931) @@ -241,4 +241,6 @@ /** * Tests whether one of the primitives matches. + * @param primitives primitives + * @return {@code true} if one of the primitives matches, {@code false} otherwise */ protected boolean existsMatch(Collection primitives) { @@ -252,4 +254,6 @@ /** * Tests whether all primitives match. + * @param primitives primitives + * @return {@code true} if all primitives match, {@code false} otherwise */ protected boolean forallMatch(Collection primitives) { Index: trunk/src/org/openstreetmap/josm/actions/upload/UploadHook.java =================================================================== --- trunk/src/org/openstreetmap/josm/actions/upload/UploadHook.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/actions/upload/UploadHook.java (revision 8931) @@ -5,7 +5,9 @@ public interface UploadHook { + /** * Checks the upload. * @param apiDataSet the data to upload + * @return {@code true} if upload is possible */ boolean checkUpload(APIDataSet apiDataSet); Index: trunk/src/org/openstreetmap/josm/command/Command.java =================================================================== --- trunk/src/org/openstreetmap/josm/command/Command.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/command/Command.java (revision 8931) @@ -220,5 +220,5 @@ /** * Replies the layer this command is (or was) applied to. - * + * @return the layer this command is (or was) applied to */ protected OsmDataLayer getLayer() { @@ -241,5 +241,6 @@ * Return the primitives that take part in this command. */ - @Override public Collection getParticipatingPrimitives() { + @Override + public Collection getParticipatingPrimitives() { return cloneMap.keySet(); } Index: trunk/src/org/openstreetmap/josm/command/PurgeCommand.java =================================================================== --- trunk/src/org/openstreetmap/josm/command/PurgeCommand.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/command/PurgeCommand.java (revision 8931) @@ -142,4 +142,5 @@ * Sorts a collection of primitives such that for each object * its referrers come later in the sorted collection. + * @return sorted list */ public static List topoSort(Collection sel) { Index: trunk/src/org/openstreetmap/josm/command/RotateCommand.java =================================================================== --- trunk/src/org/openstreetmap/josm/command/RotateCommand.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/command/RotateCommand.java (revision 8931) @@ -47,5 +47,6 @@ /** - * Get angle between the horizontal axis and the line formed by the pivot and give points. + * Get angle between the horizontal axis and the line formed by the pivot and given point. + * @return angle between the horizontal axis and the line formed by the pivot and given point **/ protected final double getAngle(EastNorth currentEN) { Index: trunk/src/org/openstreetmap/josm/command/TransformNodesCommand.java =================================================================== --- trunk/src/org/openstreetmap/josm/command/TransformNodesCommand.java (revision 8930) +++ trunk/src/org/openstreetmap/josm/command/TransformNodesCommand.java (revision 8931) @@ -119,4 +119,5 @@ /** * Get the nodes with the current transformation applied. + * @return nodes with the current transformation applied */ public Collection getTransformedNodes() { @@ -127,4 +128,5 @@ * Get the center of the nodes under modification. * It's just the barycenter. + * @return center east/north of the nodes under modification * @see org.openstreetmap.josm.tools.Geometry#getCentroid(java.util.List) */