Changeset 8876 in josm for trunk/test/unit/org/openstreetmap/josm/actions

Timestamp:

2015-10-14T23:35:44+02:00 (9 years ago)

Author:

Don-vip

Message:

cleanup unit tests

Location:

trunk/test/unit/org/openstreetmap/josm/actions

Files:

• CopyActionTest.java (modified) (1 diff)
• CreateCircleActionTest.java (modified) (4 diffs)
• SplitWayActionTest.java (modified) (1 diff)

trunk/test/unit/org/openstreetmap/josm/actions/CopyActionTest.java

@@ -26 +26 @@
     }
 
+    /**
+     * Test of {@link CopyAction#getCopyString} method for a single way.
+     */
     @Test
-    public void testCopyStringWay() throws Exception {
+    public void testCopyStringWay() {
         final Way way = new Way(123L);
         assertEquals("way 123", CopyAction.getCopyString(Collections.singleton(way)));
     }
 
+    /**
+     * Test of {@link CopyAction#getCopyString} method for a way and a relation.
+     */
     @Test
-    public void testCopyStringWayRelation() throws Exception {
+    public void testCopyStringWayRelation() {
         final Way way = new Way(123L);
         final Relation relation = new Relation(456);

trunk/test/unit/org/openstreetmap/josm/actions/CreateCircleActionTest.java

@@ -4 +4 @@
 import static org.junit.Assert.assertSame;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.fail;
 
 import java.awt.geom.Area;
@@ -50 +51 @@
      * I don't know why, but in other tests there are no problem to add selected primitives
      * but in this case there is a problem with an even listener of selection change.
+     * @param p primitive
+     * @param ds data set
      */
     public void addSelected(OsmPrimitive p, DataSet ds) {
@@ -60 +63 @@
         } catch (Exception e) {
             e.printStackTrace();
-            assertTrue("Can't add OsmPrimitive to dataset", false);
+            fail("Can't add OsmPrimitive to dataset: " + e.getMessage());
         }
     }
@@ -162 +165 @@
         } catch (Exception e) {
             e.printStackTrace();
-            assertTrue("Impossible to mock left/right hand database", false);
+            fail("Impossible to mock left/right hand database: " + e.getMessage());
         }
 

trunk/test/unit/org/openstreetmap/josm/actions/SplitWayActionTest.java

@@ -42 +42 @@
      */
     @Test
-    public void test11184() throws Exception {
+    public void testTicket11184() {
         DataSet dataSet = new DataSet();
         OsmDataLayer layer = new OsmDataLayer(dataSet, OsmDataLayer.createNewName(), null);