Changeset 8863 in josm for trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetItem.java

Timestamp:

2015-10-12T22:58:25+02:00 (9 years ago)

Author:

Don-vip

Message:

major code cleanup/refactoring of tagging presets: slay the monster TaggingPresetItems (60 Kb, 1600 lines) and extract all its internal classes to a new package gui.tagging.presets.items

Location:

trunk/src/org/openstreetmap/josm/gui/tagging/presets

Files:

• . (added)
• TaggingPresetItem.java (moved) (moved from trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItem.java ) (6 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/presets/TaggingPresetItem.java

@@ -1 +1 @@
 // License: GPL. For details, see LICENSE file.
-package org.openstreetmap.josm.gui.tagging;
+package org.openstreetmap.josm.gui.tagging.presets;
 
+import static org.openstreetmap.josm.tools.I18n.tr;
+import static org.openstreetmap.josm.tools.I18n.trc;
+
+import java.io.File;
 import java.util.Arrays;
 import java.util.Collection;
+import java.util.EnumSet;
+import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.Set;
 
+import javax.swing.ImageIcon;
 import javax.swing.JPanel;
 
@@ -15 +23 @@
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletingTextField;
 import org.openstreetmap.josm.gui.tagging.ac.AutoCompletionList;
+import org.openstreetmap.josm.tools.ImageProvider;
+import org.xml.sax.SAXException;
 
 /**
@@ -21 +31 @@
  */
 public abstract class TaggingPresetItem {
+
+    // cache the parsing of types using a LRU cache (http://java-planet.blogspot.com/2005/08/how-to-set-up-simple-lru-cache-using.html)
+    private static final Map<String, Set<TaggingPresetType>> TYPE_CACHE = new LinkedHashMap<>(16, 1.1f, true);
 
     protected void initAutoCompletionField(AutoCompletingTextField field, String... key) {
@@ -47 +60 @@
      * @return {@code true} if this item adds semantic tagging elements, {@code false} otherwise.
      */
-    abstract boolean addToPanel(JPanel p, Collection<OsmPrimitive> sel, boolean presetInitiallyMatches);
+    protected abstract boolean addToPanel(JPanel p, Collection<OsmPrimitive> sel, boolean presetInitiallyMatches);
 
     /**
@@ -53 +66 @@
      * @param changedTags The list of changed tags to modify if needed
      */
-    abstract void addCommands(List<Tag> changedTags);
-
-    boolean requestFocusInWindow() {
-        return false;
-    }
+    protected abstract void addCommands(List<Tag> changedTags);
 
     /**
@@ -65 +74 @@
      * @return {@code true} if matches (positive), {@code null} if neutral, {@code false} if mismatches (negative).
      */
-    Boolean matches(Map<String, String> tags) {
+    protected Boolean matches(Map<String, String> tags) {
         return null;
     }
+
+    protected static Set<TaggingPresetType> getType(String types) throws SAXException {
+        if (types == null || types.isEmpty()) {
+            throw new SAXException(tr("Unknown type: {0}", types));
+        }
+        if (TYPE_CACHE.containsKey(types))
+            return TYPE_CACHE.get(types);
+        Set<TaggingPresetType> result = EnumSet.noneOf(TaggingPresetType.class);
+        for (String type : Arrays.asList(types.split(","))) {
+            try {
+                TaggingPresetType presetType = TaggingPresetType.fromString(type);
+                result.add(presetType);
+            } catch (IllegalArgumentException e) {
+                throw new SAXException(tr("Unknown type: {0}", type), e);
+            }
+        }
+        TYPE_CACHE.put(types, result);
+        return result;
+    }
+
+    protected static String fixPresetString(String s) {
+        return s == null ? s : s.replaceAll("'", "''");
+    }
+
+    protected static String getLocaleText(String text, String text_context, String defaultText) {
+        if (text == null) {
+            return defaultText;
+        } else if (text_context != null) {
+            return trc(text_context, fixPresetString(text));
+        } else {
+            return tr(fixPresetString(text));
+        }
+    }
+
+    protected static Integer parseInteger(String str) {
+        if (str == null || str.isEmpty())
+            return null;
+        try {
+            return Integer.valueOf(str);
+        } catch (Exception e) {
+            if (Main.isTraceEnabled()) {
+                Main.trace(e.getMessage());
+            }
+        }
+        return null;
+    }
+
+    protected static ImageIcon loadImageIcon(String iconName, File zipIcons, Integer maxSize) {
+        final Collection<String> s = Main.pref.getCollection("taggingpreset.icon.sources", null);
+        ImageProvider imgProv = new ImageProvider(iconName).setDirs(s).setId("presets").setArchive(zipIcons).setOptional(true);
+        if (maxSize != null) {
+            imgProv.setMaxSize(maxSize);
+        }
+        return imgProv.get();
+    }
 }