Changeset 8851 in josm for trunk/src/org/openstreetmap/josm/io/GpxReader.java

Timestamp:

2015-10-10T15:47:41+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S1149 - Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used

File:

• trunk/src/org/openstreetmap/josm/io/GpxReader.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/io/GpxReader.java

@@ -7 +7 @@
 import java.io.InputStream;
 import java.io.Reader;
+import java.util.ArrayDeque;
 import java.util.ArrayList;
 import java.util.Collection;
+import java.util.Deque;
 import java.util.HashMap;
 import java.util.LinkedList;
 import java.util.List;
 import java.util.Map;
-import java.util.Stack;
 
 import javax.xml.parsers.ParserConfigurationException;
@@ -64 +65 @@
         private GpxLink currentLink;
         private Extensions currentExtensions;
-        private Stack<State> states;
-        private final Stack<String> elements = new Stack<>();
-
-        private StringBuffer accumulator = new StringBuffer();
+        private Deque<State> states;
+        private final Deque<String> elements = new ArrayDeque<>();
+
+        private StringBuilder accumulator = new StringBuilder();
 
         private boolean nokiaSportsTrackerBug;
@@ -73 +74 @@
         @Override
         public void startDocument() {
-            accumulator = new StringBuffer();
-            states = new Stack<>();
+            accumulator = new StringBuilder();
+            states = new ArrayDeque<>();
             data = new GpxData();
         }
@@ -476 +477 @@
         @Override
         public void endDocument() throws SAXException  {
-            if (!states.empty())
+            if (!states.isEmpty())
                 throw new SAXException(tr("Parse error: invalid document structure for GPX document."));
             Extensions metaExt = (Extensions) data.get(META_EXTENSIONS);