Ignore:
Timestamp:
2015-10-10T15:47:41+02:00 (9 years ago)
Author:
Don-vip
Message:

sonar - squid:S1149 - Synchronized classes Vector, Hashtable, Stack and StringBuffer should not be used

Location:
trunk/src/org/openstreetmap/josm/gui
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/org/openstreetmap/josm/gui/NavigatableComponent.java

    r8846 r8851  
    1111import java.nio.charset.StandardCharsets;
    1212import java.text.NumberFormat;
     13import java.util.ArrayDeque;
    1314import java.util.ArrayList;
    1415import java.util.Collection;
    1516import java.util.Collections;
    1617import java.util.Date;
     18import java.util.Deque;
    1719import java.util.HashSet;
    1820import java.util.LinkedList;
    … …  
    2123import java.util.Map.Entry;
    2224import java.util.Set;
    23 import java.util.Stack;
    2425import java.util.TreeMap;
    2526import java.util.concurrent.CopyOnWriteArrayList;
    … …  
    649650    }
    650651
    651     private Stack<ZoomData> zoomUndoBuffer = new Stack<>();
    652     private Stack<ZoomData> zoomRedoBuffer = new Stack<>();
     652    private Deque<ZoomData> zoomUndoBuffer = new ArrayDeque<>();
     653    private Deque<ZoomData> zoomRedoBuffer = new ArrayDeque<>();
    653654    private Date zoomTimestamp = new Date();
    654655

  • trunk/src/org/openstreetmap/josm/gui/dialogs/FilterDialog.java

    r8836 r8851  
    99import java.awt.event.KeyEvent;
    1010import java.awt.event.MouseEvent;
     11import java.util.ArrayDeque;
    1112import java.util.ArrayList;
    1213import java.util.Arrays;
    1314import java.util.Collection;
     15import java.util.Deque;
    1416import java.util.HashSet;
    1517import java.util.List;
    1618import java.util.Set;
    17 import java.util.Stack;
    1819
    1920import javax.swing.AbstractAction;
    … …  
    291292        // Filters can use nested parent/child expression so complete tree is necessary
    292293        Set<OsmPrimitive> result = new HashSet<>();
    293         Stack<OsmPrimitive> stack = new Stack<>();
     294        Deque<OsmPrimitive> stack = new ArrayDeque<>();
    294295        stack.addAll(primitives);
    295296

  • trunk/src/org/openstreetmap/josm/gui/dialogs/relation/ChildRelationBrowser.java

    r8836 r8851  
    1212import java.io.IOException;
    1313import java.net.HttpURLConnection;
     14import java.util.ArrayDeque;
     15import java.util.Deque;
    1416import java.util.HashSet;
    1517import java.util.Iterator;
    1618import java.util.List;
    1719import java.util.Set;
    18 import java.util.Stack;
    1920
    2021import javax.swing.AbstractAction;
    … …  
    329330    class DownloadAllChildrenTask extends DownloadTask {
    330331        private final Relation relation;
    331         private final Stack<Relation> relationsToDownload;
     332        private final Deque<Relation> relationsToDownload;
    332333        private final Set<Long> downloadedRelationIds;
    333334
    … …  
    335336            super(tr("Download relation members"), parent);
    336337            this.relation = r;
    337             relationsToDownload = new Stack<>();
     338            relationsToDownload = new ArrayDeque<>();
    338339            downloadedRelationIds = new HashSet<>();
    339340            relationsToDownload.push(this.relation);

  • trunk/src/org/openstreetmap/josm/gui/download/PlaceSelection.java

    r8840 r8851  
    199199    private static class NameFinderResultParser extends DefaultHandler {
    200200        private SearchResult currentResult;
    201         private StringBuffer description;
     201        private StringBuilder description;
    202202        private int depth;
    203203        private List<SearchResult> data = new LinkedList<>();
    … …  
    226226                    data.add(currentResult);
    227227                } else if ("description".equals(qName) && (depth == 3)) {
    228                     description = new StringBuffer();
     228                    description = new StringBuilder();
    229229                } else if ("named".equals(qName) && (depth == 4)) {
    230230                    // this is a "named" place in the nearest places list.

  • trunk/src/org/openstreetmap/josm/gui/layer/ImageryLayer.java

    r8846 r8851  
    2626import java.text.AttributedString;
    2727import java.util.ArrayList;
    28 import java.util.Hashtable;
     28import java.util.HashMap;
    2929import java.util.List;
    3030import java.util.Map;
    … …  
    405405            } else {
    406406                // Draw message on several lines
    407                 Map<TextAttribute, Object> map = new Hashtable<TextAttribute, Object>();
     407                Map<TextAttribute, Object> map = new HashMap<TextAttribute, Object>();
    408408                map.put(TextAttribute.FAMILY, "Serif");
    409409                map.put(TextAttribute.SIZE, new Float(18.0));

  • trunk/src/org/openstreetmap/josm/gui/layer/WMSLayer.java

    r8602 r8851  
    118118    @Override
    119119    public String nameSupportedProjections() {
    120         StringBuffer ret = new StringBuffer();
     120        StringBuilder ret = new StringBuilder();
    121121        for (String e: supportedProjections) {
    122122            ret.append(e).append(", ");
Note: See TracChangeset for help on using the changeset viewer.