Ignore:
Timestamp:
2015-10-10T01:40:42+02:00 (5 years ago)
Author:
Don-vip
Message:

sonar - fb-contrib - minor performance improvements:

  • Method passes constant String of length 1 to character overridden method
  • Method needlessly boxes a boolean constant
  • Method uses iterator().next() on a List to get the first item
  • Method converts String to boxed primitive using excessive boxing
  • Method converts String to primitive using excessive boxing
  • Method creates array using constants
  • Class defines List based fields but uses them like Sets
Location:
trunk/src/org/openstreetmap/josm/plugins
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/plugins/PluginHandler.java

    r8840 r8846  
    13901390            pl.remove(pi.name);
    13911391            pl.add(pi.name + " (" + (pi.localversion != null && !pi.localversion.isEmpty()
    1392                     ? pi.localversion : "unknown") + ")");
     1392                    ? pi.localversion : "unknown") + ')');
    13931393        }
    13941394        Collections.sort(pl);
  • trunk/src/org/openstreetmap/josm/plugins/PluginListParser.java

    r8510 r8846  
    7070                    while (line.length() > 70) {
    7171                        manifest.append(line.substring(0, 70)).append('\n');
    72                         line = " " + line.substring(70);
     72                        line = ' ' + line.substring(70);
    7373                    }
    7474                    manifest.append(line).append('\n');
Note: See TracChangeset for help on using the changeset viewer.