Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/io/OsmServerWriter.java

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/io/OsmServerWriter.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/OsmServerWriter.java

@@ -71 +71 @@
         long minutes_left = ms_left / MSECS_PER_MINUTE;
         long seconds_left = (ms_left / MSECS_PER_SECOND) % SECONDS_PER_MINUTE;
-        String time_left_str = Long.toString(minutes_left) + ":";
+        String time_left_str = Long.toString(minutes_left) + ':';
         if (seconds_left < 10) {
-            time_left_str += "0";
+            time_left_str += '0';
         }
         return time_left_str + Long.toString(seconds_left);