Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPreset.java

@@ -130 +130 @@
      */
     public String getName() {
-        return group != null ? group.getName() + "/" + getLocaleName() : getLocaleName();
+        return group != null ? group.getName() + '/' + getLocaleName() : getLocaleName();
     }
 
@@ -137 +137 @@
      */
     public String getRawName() {
-        return group != null ? group.getRawName() + "/" + name : name;
+        return group != null ? group.getRawName() + '/' + name : name;
     }