Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/gui/mappaint/NodeElemStyle.java

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/gui/mappaint/NodeElemStyle.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/gui/mappaint/NodeElemStyle.java

@@ -390 +390 @@
         s.append(super.toString());
         if (mapImage != null) {
-            s.append(" icon=[" + mapImage + "]");
+            s.append(" icon=[" + mapImage + ']');
         }
         if (symbol != null) {
-            s.append(" symbol=[" + symbol + "]");
+            s.append(" symbol=[" + symbol + ']');
         }
         if (mapImageAngle != null) {
-            s.append(" mapImageAngle=[" + mapImageAngle + "]");
+            s.append(" mapImageAngle=[" + mapImageAngle + ']');
         }
         s.append('}');