Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/validation/tests/SimilarNamedWays.java

@@ -240 +240 @@
         @Override
         public String toString() {
-            return "replaceAll(" + regExpr + ", " + replacement + ")";
+            return "replaceAll(" + regExpr + ", " + replacement + ')';
         }
     }
@@ -304 +304 @@
         @Override
         public String toString() {
-            return "synonyms(" + replacement + ", " + Arrays.toString(words) + ")";
+            return "synonyms(" + replacement + ", " + Arrays.toString(words) + ')';
         }
     }