Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/data/coor

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

Location:

trunk/src/org/openstreetmap/josm/data/coor

Files:

• CachedLatLon.java (modified) (1 diff)
• EastNorth.java (modified) (1 diff)
• LatLon.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/coor/CachedLatLon.java

@@ -63 +63 @@
     @Override
     public String toString() {
-        return "CachedLatLon[lat="+lat()+",lon="+lon()+"]";
+        return "CachedLatLon[lat="+lat()+",lon="+lon()+']';
     }
 }

trunk/src/org/openstreetmap/josm/data/coor/EastNorth.java

@@ -162 +162 @@
     }
 
-    @Override public String toString() {
-        return "EastNorth[e="+x+", n="+y+"]";
+    @Override
+    public String toString() {
+        return "EastNorth[e="+x+", n="+y+']';
     }
 

trunk/src/org/openstreetmap/josm/data/coor/LatLon.java

@@ -151 +151 @@
         }
 
-        return sDegrees + "\u00B0" + sMinutes + "\'" + sSeconds + "\"";
+        return sDegrees + '\u00B0' + sMinutes + '\'' + sSeconds + '\"';
     }
 
@@ -173 +173 @@
         }
 
-        return sDegrees + "\u00B0" + sMinutes + "\'";
+        return sDegrees + '\u00B0' + sMinutes + '\'';
     }
 
@@ -325 +325 @@
         NumberFormat nf = NumberFormat.getInstance();
         nf.setMaximumFractionDigits(5);
-        return "lat=" + nf.format(lat()) + "\u00B0, lon=" + nf.format(lon()) + "\u00B0";
+        return "lat=" + nf.format(lat()) + "\u00B0, lon=" + nf.format(lon()) + '\u00B0';
     }
 
@@ -370 +370 @@
     }
 
-    @Override public String toString() {
-        return "LatLon[lat="+lat()+",lon="+lon()+"]";
+    @Override
+    public String toString() {
+        return "LatLon[lat="+lat()+",lon="+lon()+']';
     }