Ignore:
Timestamp:
2015-10-10T01:40:42+02:00 (5 years ago)
Author:
Don-vip
Message:

sonar - fb-contrib - minor performance improvements:

  • Method passes constant String of length 1 to character overridden method
  • Method needlessly boxes a boolean constant
  • Method uses iterator().next() on a List to get the first item
  • Method converts String to boxed primitive using excessive boxing
  • Method converts String to primitive using excessive boxing
  • Method creates array using constants
  • Class defines List based fields but uses them like Sets
Location:
trunk/src/org/openstreetmap/josm/corrector
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/corrector/ReverseWayTagCorrector.java

    r8836 r8846  
    6969            this.a = a;
    7070            this.b = b;
    71             this.pattern = getPatternFor(a + "|" + b);
     71            this.pattern = getPatternFor(a + '|' + b);
    7272        }
    7373
  • trunk/src/org/openstreetmap/josm/corrector/TagCorrector.java

    r8510 r8846  
    8484
    8585                final JLabel primitiveLabel = new JLabel(
    86                         primitive.getDisplayName(DefaultNameFormatter.getInstance()) + ":",
     86                        primitive.getDisplayName(DefaultNameFormatter.getInstance()) + ':',
    8787                        ImageProvider.get(primitive.getDisplayType()),
    8888                        JLabel.LEFT
Note: See TracChangeset for help on using the changeset viewer.