Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/corrector

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

Location:

trunk/src/org/openstreetmap/josm/corrector

Files:

• ReverseWayTagCorrector.java (modified) (1 diff)
• TagCorrector.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/corrector/ReverseWayTagCorrector.java

@@ -69 +69 @@
             this.a = a;
             this.b = b;
-            this.pattern = getPatternFor(a + "|" + b);
+            this.pattern = getPatternFor(a + '|' + b);
         }
 

trunk/src/org/openstreetmap/josm/corrector/TagCorrector.java

@@ -84 +84 @@
 
                 final JLabel primitiveLabel = new JLabel(
-                        primitive.getDisplayName(DefaultNameFormatter.getInstance()) + ":",
+                        primitive.getDisplayName(DefaultNameFormatter.getInstance()) + ':',
                         ImageProvider.get(primitive.getDisplayType()),
                         JLabel.LEFT