Changeset 8846 in josm for trunk/src/org/openstreetmap/josm/command

Timestamp:

2015-10-10T01:40:42+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - fb-contrib - minor performance improvements:

• Method passes constant String of length 1 to character overridden method
• Method needlessly boxes a boolean constant
• Method uses iterator().next() on a List to get the first item
• Method converts String to boxed primitive using excessive boxing
• Method converts String to primitive using excessive boxing
• Method creates array using constants
• Class defines List based fields but uses them like Sets

Location:

trunk/src/org/openstreetmap/josm/command

Files:

• ChangePropertyCommand.java (modified) (1 diff)
• ChangePropertyKeyCommand.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/command/ChangePropertyCommand.java

@@ -141 +141 @@
         String text;
         if (objects.size() == 1 && tags.size() == 1) {
-            OsmPrimitive primitive = objects.iterator().next();
+            OsmPrimitive primitive = objects.get(0);
             String msg = "";
             Map.Entry<String, String> entry = tags.entrySet().iterator().next();

trunk/src/org/openstreetmap/josm/command/ChangePropertyKeyCommand.java

@@ -85 +85 @@
         if (objects.size() == 1) {
             NameVisitor v = new NameVisitor();
-            objects.iterator().next().accept(v);
-            text += " "+tr(v.className)+" "+v.name;
+            objects.get(0).accept(v);
+            text += ' '+tr(v.className)+' '+v.name;
         } else {
-            text += " "+objects.size()+" "+trn("object", "objects", objects.size());
+            text += ' '+objects.size()+' '+trn("object", "objects", objects.size());
         }
         return text;