Changeset 8840 in josm for trunk/src/org/openstreetmap/josm/data/validation

Timestamp:

2015-10-09T02:12:45+02:00 (9 years ago)

Author:

Don-vip

Message:

sonar - squid:S3052 - Fields should not be initialized to default values

Location:

trunk/src/org/openstreetmap/josm/data/validation

Files:

• OsmValidator.java (modified) (2 diffs)
• TestError.java (modified) (1 diff)
• tests/Coastlines.java (modified) (1 diff)
• tests/Highways.java (modified) (1 diff)
• tests/MapCSSTagChecker.java (modified) (1 diff)
• tests/RelationChecker.java (modified) (1 diff)
• tests/TagChecker.java (modified) (2 diffs)
• util/Entities.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/OsmValidator.java

@@ -73 +73 @@
 public class OsmValidator implements LayerChangeListener {
 
-    public static volatile ValidatorLayer errorLayer = null;
+    public static volatile ValidatorLayer errorLayer;
 
     /** The validate action */
@@ -297 +297 @@
     }
 
-    private static boolean testsInitialized = false;
+    private static boolean testsInitialized;
 
     /**

trunk/src/org/openstreetmap/josm/data/validation/TestError.java

@@ -33 +33 @@
 public class TestError implements Comparable<TestError>, DataSetListener {
     /** is this error on the ignore list */
-    private boolean ignored = false;
+    private boolean ignored;
     /** Severity */
     private Severity severity;

trunk/src/org/openstreetmap/josm/data/validation/tests/Coastlines.java

@@ -38 +38 @@
     private List<Way> coastlines;
 
-    private Area downloadedArea = null;
+    private Area downloadedArea;
 
     /**

trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java

@@ -58 +58 @@
     private static final Set<String> ISO_COUNTRIES = new HashSet<>(Arrays.asList(Locale.getISOCountries()));
 
-    private boolean leftByPedestrians = false;
-    private boolean leftByCyclists = false;
-    private boolean leftByCars = false;
-    private int pedestrianWays = 0;
-    private int cyclistWays = 0;
-    private int carsWays = 0;
+    private boolean leftByPedestrians;
+    private boolean leftByCyclists;
+    private boolean leftByCars;
+    private int pedestrianWays;
+    private int cyclistWays;
+    private int carsWays;
 
     /**

trunk/src/org/openstreetmap/josm/data/validation/tests/MapCSSTagChecker.java

@@ -241 +241 @@
         protected final Map<String, Boolean> assertions = new HashMap<>();
         protected final Set<String> setClassExpressions = new HashSet<>();
-        protected boolean deletion = false;
+        protected boolean deletion;
 
         TagCheck(GroupedMapCSSRule rule) {

trunk/src/org/openstreetmap/josm/data/validation/tests/RelationChecker.java

@@ -95 +95 @@
 
     private static class RoleInfo {
-        private int total = 0;
+        private int total;
     }
 

trunk/src/org/openstreetmap/josm/data/validation/tests/TagChecker.java

@@ -97 +97 @@
     public static final String PREF_CHECK_FIXMES_BEFORE_UPLOAD = PREF_CHECK_FIXMES + "BeforeUpload";
 
-    protected boolean checkKeys = false;
-    protected boolean checkValues = false;
-    protected boolean checkComplex = false;
-    protected boolean checkFixmes = false;
+    protected boolean checkKeys;
+    protected boolean checkValues;
+    protected boolean checkComplex;
+    protected boolean checkFixmes;
 
     protected JCheckBox prefCheckKeys;
@@ -667 +667 @@
             public Object value;
             public boolean noMatch;
-            public boolean tagAll = false;
-            public boolean valueAll = false;
-            public boolean valueBool = false;
+            public boolean tagAll;
+            public boolean valueAll;
+            public boolean valueBool;
 
             private Pattern getPattern(String str) throws PatternSyntaxException {

trunk/src/org/openstreetmap/josm/data/validation/util/Entities.java

@@ -334 +334 @@
     };
 
-    private static volatile Map<String, String> mapNameToValue = null;
+    private static volatile Map<String, String> mapNameToValue;
 
     public String unescape(String str) {