Changeset 8646 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2015-08-07T21:02:00+02:00 (9 years ago)

Author:

wiktorn

Message:

Move listeners notification outside synchronized sections.

Addresses: #11689

File:

• trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -417 +417 @@
             }
 
-            fireLayerAdded(layer);
             if (isOsmDataLayer) {
                 ((OsmDataLayer) layer).addLayerStateChangeListener(this);
             }
-            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
+
             layer.addPropertyChangeListener(this);
             Main.addProjectionChangeListener(layer);
             AudioPlayer.reset();
         }
+        fireLayerAdded(layer);
+        onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
+
         if (!listenersToFire.isEmpty()) {
             repaint();
@@ -518 +520 @@
             layers.remove(layer);
             Main.removeProjectionChangeListener(layer);
-
-            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
-            fireLayerRemoved(layer);
             layer.removePropertyChangeListener(this);
             layer.destroy();
             AudioPlayer.reset();
         }
+        onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
+        fireLayerRemoved(layer);
+
         repaint();
     }
@@ -576 +578 @@
             }
             listenersToFire = setEditLayer(layers);
-            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
             AudioPlayer.reset();
         }
+        onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
+
         repaint();
     }
@@ -922 +925 @@
     public void setActiveLayer(Layer layer) {
         EnumSet<LayerListenerType> listenersToFire;
-
-        synchronized (layers) {
-            Layer oldActiveLayer = activeLayer;
-            OsmDataLayer oldEditLayer = editLayer;
+        Layer oldActiveLayer;
+        OsmDataLayer oldEditLayer;
+
+        synchronized (layers) {
+            oldActiveLayer = activeLayer;
+            oldEditLayer = editLayer;
             listenersToFire = setActiveLayer(layer, true);
-            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
-        }
+        }
+        onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
+
         repaint();
     }