Changeset 8573 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2015-07-05T18:20:17+02:00 (9 years ago)

Author:

bastiK

Message:

fixed #11647 - Regression: relation list empty (patch by michael2402)

File:

• trunk/src/org/openstreetmap/josm/gui/MapView.java (modified) (15 diffs)

trunk/src/org/openstreetmap/josm/gui/MapView.java

@@ -27 +27 @@
 import java.util.Collections;
 import java.util.Comparator;
+import java.util.EnumSet;
 import java.util.LinkedHashSet;
 import java.util.List;
@@ -407 +408 @@
         layerLock.writeLock().lock();
         layerLock.readLock().lock();
-        boolean fireSetActiveLayer = false;
+        EnumSet<LayerListenerType> listenersToFire = EnumSet.noneOf(LayerListenerType.class);
         Layer oldActiveLayer = activeLayer;
+        OsmDataLayer oldEditLayer = editLayer;
         try {
             try {
@@ -433 +435 @@
                 if (isOsmDataLayer || oldActiveLayer == null) {
                     // autoselect the new layer
-                    fireSetActiveLayer = setActiveLayer(layer, true);
+                    listenersToFire.addAll(setActiveLayer(layer, true));
                 }
             } finally {
@@ -443 +445 @@
                 ((OsmDataLayer) layer).addLayerStateChangeListener(this);
             }
-            if (fireSetActiveLayer) {
-                onActiveLayerChanged(oldActiveLayer);
-            }
+            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
             layer.addPropertyChangeListener(this);
             Main.addProjectionChangeListener(layer);
@@ -452 +452 @@
             layerLock.readLock().unlock();
         }
-        if (!fireSetActiveLayer) {
+        if (!listenersToFire.isEmpty()) {
             repaint();
         }
@@ -531 +531 @@
      */
     public void removeLayer(Layer layer) {
-        boolean fireEditLayerChanged;
-        boolean fireSetActiveLayer = false;
         layerLock.writeLock().lock();
         layerLock.readLock().lock();
 
+        EnumSet<LayerListenerType> listenersToFire = EnumSet.noneOf(LayerListenerType.class);
+        Layer oldActiveLayer = activeLayer;
         OsmDataLayer oldEditLayer = editLayer;
-        Layer oldActiveLayer = activeLayer;
-
         try {
             try {
@@ -546 +544 @@
                     return;
 
-                fireEditLayerChanged = setEditLayer(layersList);
+                listenersToFire = setEditLayer(layersList);
 
                 if (layer == activeLayer) {
-                    fireSetActiveLayer = setActiveLayer(determineNextActiveLayer(layersList), false);
+                    listenersToFire.addAll(setActiveLayer(determineNextActiveLayer(layersList), false));
                 }
 
@@ -562 +560 @@
                 layerLock.writeLock().unlock();
             }
-            if (fireEditLayerChanged) {
-               onEditLayerChanged(oldEditLayer);
-            }
-            if (fireSetActiveLayer) {
-                onActiveLayerChanged(oldActiveLayer);
-            }
+            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
             fireLayerRemoved(layer);
             layer.removePropertyChangeListener(this);
@@ -611 +604 @@
         layerLock.writeLock().lock();
         layerLock.readLock().lock();
-        boolean fireEditLayerChanged;
+        EnumSet<LayerListenerType> listenersToFire;
+        Layer oldActiveLayer = activeLayer;
         OsmDataLayer oldEditLayer = editLayer;
         try {
@@ -626 +620 @@
                     layers.add(pos, layer);
                 }
-                fireEditLayerChanged = setEditLayer(layers);
+                listenersToFire = setEditLayer(layers);
             } finally {
                 layerLock.writeLock().unlock();
             }
-            if (fireEditLayerChanged) {
-                onEditLayerChanged(editLayer);
-            }
+            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
             AudioPlayer.reset();
         } finally {
@@ -946 +938 @@
      * You must own a write {@link #layerLock} when calling this method.
      * @param layersList A list to select that layer from.
-     * @return <code>true</code> if the edit layer was really changed and the listeners should be informed.
-     */
-    private boolean setEditLayer(List<Layer> layersList) {
+     * @return A list of change listeners that should be fired using {@link #onActiveEditLayerChanged(Layer, OsmDataLayer, EnumSet)}
+     */
+    private EnumSet<LayerListenerType> setEditLayer(List<Layer> layersList) {
         final OsmDataLayer newEditLayer = findNewEditLayer(layersList);
 
@@ -959 +951 @@
 
             editLayer = newEditLayer;
-            return true;
+            return EnumSet.of(LayerListenerType.EDIT_LAYER_CHANGE);
         } else {
-            return false;
+            return EnumSet.noneOf(LayerListenerType.class);
         }
 
@@ -994 +986 @@
         layerLock.writeLock().lock();
         layerLock.readLock().lock();
+        EnumSet<LayerListenerType> listenersToFire;
         Layer oldActiveLayer = activeLayer;
-        try {
-            boolean fireSetActiveLayer;
+        OsmDataLayer oldEditLayer = editLayer;
+        try {
             try {
-                fireSetActiveLayer = setActiveLayer(layer, true);
+                listenersToFire = setActiveLayer(layer, true);
             } finally {
                 layerLock.writeLock().unlock();
             }
-            if (fireSetActiveLayer) {
-                onActiveLayerChanged(oldActiveLayer);
-            }
+            onActiveEditLayerChanged(oldActiveLayer, oldEditLayer, listenersToFire);
         } finally {
             layerLock.readLock().unlock();
@@ -1015 +1006 @@
      * @param layer The layer to be active.
      * @param setEditLayer if this is <code>true</code>, the edit layer is also set.
-     * @return {@code true} if the active layer has changed, {@code false otherwise}
-     */
-    private boolean setActiveLayer(final Layer layer, boolean setEditLayer) {
+     * @return A list of change listeners that should be fired using {@link #onActiveEditLayerChanged(Layer, OsmDataLayer, EnumSet)}
+     */
+    private EnumSet<LayerListenerType> setActiveLayer(final Layer layer, boolean setEditLayer) {
         if (layer != null && !layers.contains(layer))
             throw new IllegalArgumentException(tr("Layer ''{0}'' must be in list of layers", layer.toString()));
 
         if (layer == activeLayer)
-            return false;
+            return EnumSet.noneOf(LayerListenerType.class);
 
         activeLayer = layer;
+        EnumSet<LayerListenerType> listenersToFire = EnumSet.of(LayerListenerType.ACTIVE_LAYER_CHANGE);
         if (setEditLayer) {
-            setEditLayer(layers);
-        }
-
-        return true;
+            listenersToFire.addAll(setEditLayer(layers));
+        }
+
+        return listenersToFire;
     }
 
@@ -1043 +1035 @@
         } finally {
             layerLock.readLock().unlock();
+        }
+    }
+
+    private enum LayerListenerType {
+        ACTIVE_LAYER_CHANGE,
+        EDIT_LAYER_CHANGE
+    }
+
+    /**
+     * This is called whenever one of active layer/edit layer or both may have been changed,
+     * @param oldActive The old active layer
+     * @param oldEdit The old edit layer.
+     * @param listenersToFire A mask of listeners to fire using {@link LayerListenerType}s
+     */
+    private void onActiveEditLayerChanged(final Layer oldActive, final OsmDataLayer oldEdit, EnumSet<LayerListenerType> listenersToFire) {
+        if (listenersToFire.contains(LayerListenerType.EDIT_LAYER_CHANGE)) {
+            onEditLayerChanged(oldEdit);
+        }
+        if (listenersToFire.contains(LayerListenerType.ACTIVE_LAYER_CHANGE)) {
+            onActiveLayerChanged(oldActive);
         }
     }