Changeset 8567 in josm for trunk/src/org/openstreetmap/josm/tools

Timestamp:

2015-07-04T18:53:26+02:00 (10 years ago)

Author:

Don-vip

Message:

fix #11651 - whitechars stripping optimization (modified patch by shinigami)

File:

• trunk/src/org/openstreetmap/josm/tools/Utils.java (modified) (14 diffs)

trunk/src/org/openstreetmap/josm/tools/Utils.java

@@ -40 +40 @@
 import java.util.Collection;
 import java.util.Collections;
-import java.util.HashSet;
 import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
-import java.util.Set;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
@@ -83 +81 @@
 
     public static final String URL_CHARS = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~:/?#[]@!$&'()*+,;=%";
+
+    private static char[] DEFAULT_STRIP = {'\u200B', '\uFEFF'};
 
     /**
@@ -902 +902 @@
      */
     public static String strip(final String str) {
-        return strip(str, null);
+        if (str == null || str.isEmpty()) {
+            return str;
+        }
+        return strip(str, DEFAULT_STRIP);
     }
 
@@ -917 +920 @@
             return str;
         }
-        // create set with chars to skip
-        Set<Character> skipSet = new HashSet<>();
-        // '\u200B' (ZERO WIDTH SPACE character) needs to be handled manually because of change in Unicode 6.0 (Java 7, see #8918)
-        skipSet.add('\u200B');
-        // same for '\uFEFF' (ZERO WIDTH NO-BREAK SPACE)
-        skipSet.add('\uFEFF');
-        if (skipChars != null) {
-            for (char c : skipChars.toCharArray()) {
-                skipSet.add(c);
-            }
-        }
+        return strip(str, stripChars(skipChars));
+    }
+
+    private static String strip(final String str, final char[] skipChars) {
+
         int start = 0;
         int end = str.length();
@@ -933 +930 @@
         while (leadingSkipChar && start < end) {
             char c = str.charAt(start);
-            leadingSkipChar = Character.isWhitespace(c) || Character.isSpaceChar(c) || skipSet.contains(c);
+            leadingSkipChar = Character.isWhitespace(c) || Character.isSpaceChar(c) || stripChar(skipChars, c);
             if (leadingSkipChar) {
                 start++;
@@ -939 +936 @@
         }
         boolean trailingSkipChar = true;
-        while (trailingSkipChar && end > start+1) {
-            char c = str.charAt(end-1);
-            trailingSkipChar = Character.isWhitespace(c) || Character.isSpaceChar(c) || skipSet.contains(c);
+        while (trailingSkipChar && end > start + 1) {
+            char c = str.charAt(end - 1);
+            trailingSkipChar = Character.isWhitespace(c) || Character.isSpaceChar(c) || stripChar(skipChars, c);
             if (trailingSkipChar) {
                 end--;
             }
         }
+
         return str.substring(start, end);
+    }
+
+    private static char[] stripChars(final String skipChars) {
+        if (skipChars == null || skipChars.isEmpty()) {
+            return DEFAULT_STRIP;
+        }
+
+        char[] chars = new char[DEFAULT_STRIP.length + skipChars.length()];
+        System.arraycopy(DEFAULT_STRIP, 0, chars, 0, DEFAULT_STRIP.length);
+        skipChars.getChars(0, skipChars.length(), chars, DEFAULT_STRIP.length);
+
+        return chars;
+    }
+
+    private static boolean stripChar(final char[] strip, char c) {
+        for (char s : strip) {
+            if (c == s) {
+                return true;
+            }
+        }
+        return false;
     }
 
@@ -990 +1009 @@
         File josmTmpDir = new File(tmpDir, "JOSM");
         if (!josmTmpDir.exists() && !josmTmpDir.mkdirs()) {
-            Main.warn("Unable to create temp directory "+josmTmpDir);
+            Main.warn("Unable to create temp directory " + josmTmpDir);
         }
         return josmTmpDir;
@@ -1035 +1054 @@
      * @return a human readable representation
      */
-    public static String getPositionListString(List<Integer> positionList)  {
+    public static String getPositionListString(List<Integer> positionList) {
         Collections.sort(positionList);
         final StringBuilder sb = new StringBuilder(32);
@@ -1060 +1079 @@
     }
 
-
     /**
      * Returns a list of capture groups if {@link Matcher#matches()}, or {@code null}.
@@ -1159 +1177 @@
 
         for (int i = 0; i < query.length(); i++) {
-            String c = query.substring(i, i+1);
+            String c = query.substring(i, i + 1);
             if (URL_CHARS.contains(c)) {
                 sb.append(c);
@@ -1246 +1264 @@
             String old = System.setProperty(key, value);
             if (!key.toLowerCase(Locale.ENGLISH).contains("password")) {
-                Main.debug("System property '"+key+"' set to '"+value+"'. Old value was '"+old+"'");
+                Main.debug("System property '" + key + "' set to '" + value + "'. Old value was '" + old + "'");
             } else {
-                Main.debug("System property '"+key+"' changed.");
+                Main.debug("System property '" + key + "' changed.");
             }
             return old;
@@ -1283 +1301 @@
         long start = System.currentTimeMillis();
         if (Main.isDebugEnabled()) {
-            Main.debug("Starting SAX parsing of "+is+" using "+dh);
+            Main.debug("Starting SAX parsing of " + is + " using " + dh);
         }
         newSafeSAXParser().parse(is, dh);
         if (Main.isDebugEnabled()) {
-            Main.debug("SAX parsing done in " + getDurationString(System.currentTimeMillis()-start));
+            Main.debug("SAX parsing done in " + getDurationString(System.currentTimeMillis() - start));
         }
     }
@@ -1299 +1317 @@
      * @since 8404
      */
-    public static boolean hasExtension(String filename, String ... extensions) {
+    public static boolean hasExtension(String filename, String... extensions) {
         String name = filename.toLowerCase(Locale.ENGLISH);
         for (String ext : extensions) {
-            if (name.endsWith("."+ext.toLowerCase(Locale.ENGLISH)))
+            if (name.endsWith("." + ext.toLowerCase(Locale.ENGLISH)))
                 return true;
         }
@@ -1316 +1334 @@
      * @since 8404
      */
-    public static boolean hasExtension(File file, String ... extensions) {
+    public static boolean hasExtension(File file, String... extensions) {
         return hasExtension(file.getName(), extensions);
     }