Changeset 8488 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2015-06-12T22:51:43+02:00 (9 years ago)

Author:

wiktorn

Message:

Properly handle situation, when tile server returns something else than image file but still gives http status code 200 (like html error page). Closes #11553

Location:

trunk/src/org/openstreetmap/josm/data

Files:

• cache/BufferedImageCacheEntry.java (modified) (2 diffs)
• imagery/TMSCachedTileLoaderJob.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/data/cache/BufferedImageCacheEntry.java

@@ -20 +20 @@
     private transient volatile BufferedImage img = null;
     private transient volatile boolean writtenToDisk = false;
+    // we need to have separate control variable, to know, if we already tried to load the image, as img might be null
+    // after we loaded image, as for example, when image file is malformed (eg. HTML file)
+    private transient volatile boolean imageLoaded = false;
 
     /**
@@ -37 +40 @@
      */
     public BufferedImage getImage() throws IOException {
-        if (img != null)
+        if (imageLoaded)
             return img;
         synchronized(this) {
-            if (img != null)
+            if (imageLoaded)
                 return img;
             byte[] content = getContent();
             if (content != null && content.length > 0) {
                 img = ImageIO.read(new ByteArrayInputStream(content));
+                imageLoaded = true;
 
                 if (writtenToDisk)

trunk/src/org/openstreetmap/josm/data/imagery/TMSCachedTileLoaderJob.java

@@ -193 +193 @@
                         if (content != null && content.length > 0) {
                             tile.loadImage(new ByteArrayInputStream(content));
+                            if (tile.getImage() == null) {
+                                tile.setError(tr("Could not load image from tile server"));
+                                status = false;
+                            }
                         }
                     }
@@ -242 +246 @@
                 }
 
-                if (data != null && data.getImage() != null) {
-                    tile.setImage(data.getImage());
-                    tile.finishLoading();
+                if (data != null) {
+                    if (data.getImage() != null) {
+                        tile.setImage(data.getImage());
+                        tile.finishLoading();
+                    } else {
+                        // we had some data, but we didn't get any image. Malformed image?
+                        tile.setError(tr("Could not load image from tile server"));
+                    }
                 }
                 if (isNoTileAtZoom()) {