Changeset 8404 in josm for trunk/src/org/openstreetmap/josm/gui/io

Timestamp:

2015-05-21T01:18:35+02:00 (9 years ago)

Author:

Don-vip

Message:

When doing a String.toLowerCase()/toUpperCase() call, use a Locale. This avoids problems with certain locales, i.e. Lithuanian or Turkish. See PMD UseLocaleWithCaseConversions rule and String.toLowerCase() javadoc.

File:

• trunk/src/org/openstreetmap/josm/gui/io/UploadStrategy.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/io/UploadStrategy.java

@@ -3 +3 @@
 
 import static org.openstreetmap.josm.tools.I18n.tr;
+
+import java.util.Locale;
 
 import org.openstreetmap.josm.Main;
@@ -28 +30 @@
     public static UploadStrategy fromPreference(String preferenceValue) {
         if (preferenceValue == null) return null;
-        preferenceValue = preferenceValue.trim().toLowerCase();
+        preferenceValue = preferenceValue.trim().toLowerCase(Locale.ENGLISH);
         for (UploadStrategy strategy: values()) {
             if (strategy.getPreferenceValue().equals(preferenceValue))
@@ -76 +78 @@
                 v = "";
             }
-            v = v.trim().toLowerCase();
+            v = v.trim().toLowerCase(Locale.ENGLISH);
             if ("true".equals(v))
                 return SINGLE_REQUEST_STRATEGY;