Changeset 8377 in josm for trunk/src/org/openstreetmap/josm/actions

Timestamp:

2015-05-17T04:02:42+02:00 (9 years ago)

Author:

Don-vip

Message:

performance - remove useless boxing of boolean constants

Location:

trunk/src/org/openstreetmap/josm/actions

Files:

• CloseChangesetAction.java (modified) (1 diff)
• DistributeAction.java (modified) (1 diff)
• ImageryAdjustAction.java (modified) (1 diff)
• mapmode/MapMode.java (modified) (3 diffs)
• search/SearchAction.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/CloseChangesetAction.java

@@ -84 +84 @@
         private UserInfo userInfo;
 
-        public DownloadOpenChangesetsTask() {
-            super(tr("Downloading open changesets ...", false /* don't ignore exceptions */));
+        private DownloadOpenChangesetsTask() {
+            super(tr("Downloading open changesets ..."), false /* don't ignore exceptions */);
         }
 

trunk/src/org/openstreetmap/josm/actions/DistributeAction.java

@@ -111 +111 @@
      * @return true in this case
      */
-    private Boolean checkDistributeWay(Collection<Way> ways, Collection<Node> nodes) {
+    private boolean checkDistributeWay(Collection<Way> ways, Collection<Node> nodes) {
         if(ways.size() == 1 && nodes.size() <= 2) {
             Way w = ways.iterator().next();

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -57 +57 @@
                 tr("Adjust the position of this imagery layer"), Main.map,
                 cursor);
-        putValue("toolbar", false);
+        putValue("toolbar", Boolean.FALSE);
         this.layer = layer;
     }

trunk/src/org/openstreetmap/josm/actions/mapmode/MapMode.java

@@ -36 +36 @@
         super(name, "mapmode/"+iconName, tooltip, shortcut, false);
         this.cursor = cursor;
-        putValue("active", false);
+        putValue("active", Boolean.FALSE);
     }
 
@@ -53 +53 @@
      */
     public void enterMode() {
-        putValue("active", true);
+        putValue("active", Boolean.TRUE);
         Main.map.mapView.setNewCursor(cursor, this);
         updateStatusLine();
@@ -62 +62 @@
      */
     public void exitMode() {
-        putValue("active", false);
+        putValue("active", Boolean.FALSE);
         Main.map.mapView.resetCursor(this);
     }

trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

@@ -505 +505 @@
                 if (s.mode == SearchMode.replace) {
                     if (matcher.match(osm)) {
-                        p.set(osm, true);
+                        p.set(osm, Boolean.TRUE);
                     } else {
-                        p.set(osm, false);
+                        p.set(osm, Boolean.FALSE);
                     }
                 } else if (s.mode == SearchMode.add && !p.get(osm) && matcher.match(osm)) {
-                    p.set(osm, true);
+                    p.set(osm, Boolean.TRUE);
                 } else if (s.mode == SearchMode.remove && p.get(osm) && matcher.match(osm)) {
-                    p.set(osm, false);
+                    p.set(osm, Boolean.FALSE);
                 } else if (s.mode == SearchMode.in_selection && p.get(osm) && !matcher.match(osm)) {
-                    p.set(osm, false);
+                    p.set(osm, Boolean.FALSE);
                 }
             }
@@ -523 +523 @@
                     tr("Error"),
                     JOptionPane.ERROR_MESSAGE
-
             );
         }