Changeset 8377 in josm for trunk/src/org/openstreetmap/josm

Timestamp:

2015-05-17T04:02:42+02:00 (9 years ago)

Author:

Don-vip

Message:

performance - remove useless boxing of boolean constants

Location:

trunk/src/org/openstreetmap/josm

Files:

• actions/CloseChangesetAction.java (modified) (1 diff)
• actions/DistributeAction.java (modified) (1 diff)
• actions/ImageryAdjustAction.java (modified) (1 diff)
• actions/mapmode/MapMode.java (modified) (3 diffs)
• actions/search/SearchAction.java (modified) (2 diffs)
• data/notes/NoteComment.java (modified) (3 diffs)
• data/osm/visitor/paint/StyledMapRenderer.java (modified) (2 diffs)
• data/validation/TestError.java (modified) (2 diffs)
• gui/MainApplication.java (modified) (1 diff)
• gui/conflict/pair/ListMerger.java (modified) (2 diffs)
• gui/dialogs/LayerListDialog.java (modified) (1 diff)
• gui/dialogs/MapPaintDialog.java (modified) (1 diff)
• gui/dialogs/ToggleDialog.java (modified) (1 diff)
• gui/dialogs/changeset/query/ChangesetQueryTask.java (modified) (2 diffs)
• gui/history/VersionTable.java (modified) (1 diff)
• gui/io/RecentlyOpenedFilesMenu.java (modified) (1 diff)
• gui/mappaint/ElemStyle.java (modified) (1 diff)
• gui/mappaint/ElemStyles.java (modified) (2 diffs)
• gui/mappaint/MultiCascade.java (modified) (1 diff)
• gui/mappaint/mapcss/ExpressionFactory.java (modified) (2 diffs)
• gui/preferences/SourceEditor.java (modified) (1 diff)
• gui/preferences/SourceEntry.java (modified) (1 diff)
• gui/preferences/advanced/ListEditor.java (modified) (1 diff)
• gui/preferences/advanced/ListListEditor.java (modified) (1 diff)
• gui/preferences/advanced/MapListEditor.java (modified) (1 diff)
• gui/preferences/advanced/PreferencesTable.java (modified) (1 diff)
• gui/preferences/display/ColorPreference.java (modified) (2 diffs)
• gui/preferences/imagery/ImageryPreference.java (modified) (1 diff)
• gui/preferences/plugin/PluginPreferencesModel.java (modified) (1 diff)
• gui/progress/AbstractProgressMonitor.java (modified) (2 diffs)
• gui/tagging/TaggingPresetItems.java (modified) (1 diff)
• gui/widgets/AbstractTextComponentValidator.java (modified) (2 diffs)
• gui/widgets/JosmComboBox.java (modified) (1 diff)
• gui/widgets/JosmEditorPane.java (modified) (1 diff)
• io/NoteReader.java (modified) (3 diffs)
• io/remotecontrol/RemoteControlHttpsServer.java (modified) (3 diffs)
• tools/PlatformHookOsx.java (modified) (1 diff)
• tools/RightAndLefthandTraffic.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/actions/CloseChangesetAction.java

@@ -84 +84 @@
         private UserInfo userInfo;
 
-        public DownloadOpenChangesetsTask() {
-            super(tr("Downloading open changesets ...", false /* don't ignore exceptions */));
+        private DownloadOpenChangesetsTask() {
+            super(tr("Downloading open changesets ..."), false /* don't ignore exceptions */);
         }
 

trunk/src/org/openstreetmap/josm/actions/DistributeAction.java

@@ -111 +111 @@
      * @return true in this case
      */
-    private Boolean checkDistributeWay(Collection<Way> ways, Collection<Node> nodes) {
+    private boolean checkDistributeWay(Collection<Way> ways, Collection<Node> nodes) {
         if(ways.size() == 1 && nodes.size() <= 2) {
             Way w = ways.iterator().next();

trunk/src/org/openstreetmap/josm/actions/ImageryAdjustAction.java

@@ -57 +57 @@
                 tr("Adjust the position of this imagery layer"), Main.map,
                 cursor);
-        putValue("toolbar", false);
+        putValue("toolbar", Boolean.FALSE);
         this.layer = layer;
     }

trunk/src/org/openstreetmap/josm/actions/mapmode/MapMode.java

@@ -36 +36 @@
         super(name, "mapmode/"+iconName, tooltip, shortcut, false);
         this.cursor = cursor;
-        putValue("active", false);
+        putValue("active", Boolean.FALSE);
     }
 
@@ -53 +53 @@
      */
     public void enterMode() {
-        putValue("active", true);
+        putValue("active", Boolean.TRUE);
         Main.map.mapView.setNewCursor(cursor, this);
         updateStatusLine();
@@ -62 +62 @@
      */
     public void exitMode() {
-        putValue("active", false);
+        putValue("active", Boolean.FALSE);
         Main.map.mapView.resetCursor(this);
     }

trunk/src/org/openstreetmap/josm/actions/search/SearchAction.java

@@ -505 +505 @@
                 if (s.mode == SearchMode.replace) {
                     if (matcher.match(osm)) {
-                        p.set(osm, true);
+                        p.set(osm, Boolean.TRUE);
                     } else {
-                        p.set(osm, false);
+                        p.set(osm, Boolean.FALSE);
                     }
                 } else if (s.mode == SearchMode.add && !p.get(osm) && matcher.match(osm)) {
-                    p.set(osm, true);
+                    p.set(osm, Boolean.TRUE);
                 } else if (s.mode == SearchMode.remove && p.get(osm) && matcher.match(osm)) {
-                    p.set(osm, false);
+                    p.set(osm, Boolean.FALSE);
                 } else if (s.mode == SearchMode.in_selection && p.get(osm) && !matcher.match(osm)) {
-                    p.set(osm, false);
+                    p.set(osm, Boolean.FALSE);
                 }
             }
@@ -523 +523 @@
                     tr("Error"),
                     JOptionPane.ERROR_MESSAGE
-
             );
         }

trunk/src/org/openstreetmap/josm/data/notes/NoteComment.java

@@ -18 +18 @@
 
     //not currently used. I'm planning on using this to keep track of new actions that need to be uploaded
-    private Boolean isNew;
+    private boolean isNew;
 
     /**
@@ -33 +33 @@
      * @param isNew Whether or not this comment is new and needs to be uploaded
      */
-    public NoteComment(Date createDate, User user, String commentText, Action action, Boolean isNew) {
+    public NoteComment(Date createDate, User user, String commentText, Action action, boolean isNew) {
         this.text = commentText;
         this.user = user;
@@ -61 +61 @@
     }
 
-    public void setIsNew(Boolean isNew) {
+    public void setIsNew(boolean isNew) {
         this.isNew = isNew;
     }
 
     /** @return true if this is a new comment/action and needs to be uploaded to the API */
-    public Boolean getIsNew() {
+    public boolean getIsNew() {
         return isNew;
     }

trunk/src/org/openstreetmap/josm/data/osm/visitor/paint/StyledMapRenderer.java

@@ -954 +954 @@
             Node firstNode = viaWay.firstNode();
             Node lastNode = viaWay.lastNode();
-            Boolean onewayvia = false;
+            Boolean onewayvia = Boolean.FALSE;
 
             String onewayviastr = viaWay.get("oneway");
             if(onewayviastr != null) {
                 if("-1".equals(onewayviastr)) {
-                    onewayvia = true;
+                    onewayvia = Boolean.TRUE;
                     Node tmp = firstNode;
                     firstNode = lastNode;
@@ -966 +966 @@
                     onewayvia = OsmUtils.getOsmBoolean(onewayviastr);
                     if (onewayvia == null) {
-                        onewayvia = false;
+                        onewayvia = Boolean.FALSE;
                     }
                 }

trunk/src/org/openstreetmap/josm/data/validation/TestError.java

@@ -33 +33 @@
 public class TestError implements Comparable<TestError>, DataSetListener {
     /** is this error on the ignore list */
-    private Boolean ignored = false;
+    private boolean ignored = false;
     /** Severity */
     private Severity severity;
@@ -208 +208 @@
     }
 
-    public Boolean getIgnored() {
+    public boolean getIgnored() {
         return ignored;
     }

trunk/src/org/openstreetmap/josm/gui/MainApplication.java

@@ -349 +349 @@
         }
 
-        Boolean skipLoadingPlugins = false;
+        boolean skipLoadingPlugins = false;
         if (args.containsKey(Option.SKIP_PLUGINS)) {
             skipLoadingPlugins = true;

trunk/src/org/openstreetmap/josm/gui/conflict/pair/ListMerger.java

@@ -774 +774 @@
     }
 
-    public static interface FreezeActionProperties {
+    private static interface FreezeActionProperties {
         String PROP_SELECTED = FreezeActionProperties.class.getName() + ".selected";
     }
@@ -782 +782 @@
      *
      */
-    class FreezeAction extends AbstractAction implements ItemListener, FreezeActionProperties  {
-
-        public FreezeAction() {
+    private class FreezeAction extends AbstractAction implements ItemListener, FreezeActionProperties  {
+
+        private FreezeAction() {
             putValue(Action.NAME, tr("Freeze"));
             putValue(Action.SHORT_DESCRIPTION, tr("Freeze the current list of merged elements."));
-            putValue(PROP_SELECTED, false);
+            putValue(PROP_SELECTED, Boolean.FALSE);
             setEnabled(true);
         }

trunk/src/org/openstreetmap/josm/gui/dialogs/LayerListDialog.java

@@ -173 +173 @@
         layerList.addMouseListener(new PopupMenuHandler());
         layerList.setBackground(UIManager.getColor("Button.background"));
-        layerList.putClientProperty("terminateEditOnFocusLost", true);
-        layerList.putClientProperty("JTable.autoStartsEdit", false);
+        layerList.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
+        layerList.putClientProperty("JTable.autoStartsEdit", Boolean.FALSE);
         layerList.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);
         layerList.setTableHeader(null);

trunk/src/org/openstreetmap/josm/gui/dialogs/MapPaintDialog.java

@@ -140 +140 @@
         tblStyles.setSelectionModel(selectionModel= new DefaultListSelectionModel());
         tblStyles.addMouseListener(new PopupMenuHandler());
-        tblStyles.putClientProperty("terminateEditOnFocusLost", true);
+        tblStyles.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         tblStyles.setBackground(UIManager.getColor("Panel.background"));
         tblStyles.setSelectionMode(ListSelectionModel.MULTIPLE_INTERVAL_SELECTION);

trunk/src/org/openstreetmap/josm/gui/dialogs/ToggleDialog.java

@@ -312 +312 @@
         setIsShowing(true);
         windowMenuItem.setState(true);
-        toggleAction.putValue("selected", false);
-        toggleAction.putValue("selected", true);
+        toggleAction.putValue("selected", Boolean.FALSE);
+        toggleAction.putValue("selected", Boolean.TRUE);
     }
 

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/query/ChangesetQueryTask.java

@@ -33 +33 @@
 /**
  * Asynchronous task to send a changeset query to the OSM API.
- *
+ * @since 2689
  */
 public class ChangesetQueryTask extends PleaseWaitRunnable implements ChangesetDownloadTask{
@@ -57 +57 @@
      */
     public ChangesetQueryTask(ChangesetQuery query) {
-        super(tr("Querying and downloading changesets",false /* don't ignore exceptions */));
+        super(tr("Querying and downloading changesets"), false /* don't ignore exceptions */);
         CheckParameterUtil.ensureParameterNotNull(query, "query");
         this.query = query;

trunk/src/org/openstreetmap/josm/gui/history/VersionTable.java

@@ -55 +55 @@
         setBackground(UIManager.getColor("Button.background"));
         setIntercellSpacing(new Dimension(6, 0));
-        putClientProperty("terminateEditOnFocusLost", true);
+        putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         popupMenu = new VersionTablePopupMenu();
         addMouseListener(new MouseListener());

trunk/src/org/openstreetmap/josm/gui/io/RecentlyOpenedFilesMenu.java

@@ -59 +59 @@
                     putValue(NAME, file);
                     putValue("help", ht("/Action/OpenRecent"));
-                    putValue("toolbar", false);
+                    putValue("toolbar", Boolean.FALSE);
                 }
                 @Override

trunk/src/org/openstreetmap/josm/gui/mappaint/ElemStyle.java

@@ -40 +40 @@
         zIndex = c.get(Z_INDEX, 0f, Float.class);
         objectZIndex = c.get(OBJECT_Z_INDEX, 0f, Float.class);
-        isModifier = c.get(MODIFIER, false, Boolean.class);
+        isModifier = c.get(MODIFIER, Boolean.FALSE, Boolean.class);
     }
 

trunk/src/org/openstreetmap/josm/gui/mappaint/ElemStyles.java

@@ -369 +369 @@
         if (defaultNodesIdx == cacheIdx)
             return defaultNodes;
-        defaultNodes = fromCanvas("default-points", true, Boolean.class);
+        defaultNodes = fromCanvas("default-points", Boolean.TRUE, Boolean.class);
         defaultNodesIdx = cacheIdx;
         return defaultNodes;
@@ -380 +380 @@
         if (defaultLinesIdx == cacheIdx)
             return defaultLines;
-        defaultLines = fromCanvas("default-lines", true, Boolean.class);
+        defaultLines = fromCanvas("default-lines", Boolean.TRUE, Boolean.class);
         defaultLinesIdx = cacheIdx;
         return defaultLines;

trunk/src/org/openstreetmap/josm/gui/mappaint/MultiCascade.java

@@ -64 +64 @@
             c = new Cascade();
             if (!"default".equals(layer) && !"*".equals(layer)) {
-                c.put(MODIFIER, true);
+                c.put(MODIFIER, Boolean.TRUE);
             }
         }

trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/ExpressionFactory.java

@@ -969 +969 @@
                 Boolean b = Cascade.convertTo(arg.evaluate(env), boolean.class);
                 if (b == null || !b) {
-                    return false;
+                    return Boolean.FALSE;
                 }
             }
-            return true;
+            return Boolean.TRUE;
         }
     }
@@ -996 +996 @@
                 Boolean b = Cascade.convertTo(arg.evaluate(env), boolean.class);
                 if (b != null && b) {
-                    return true;
+                    return Boolean.TRUE;
                 }
             }
-            return false;
+            return Boolean.FALSE;
         }
     }

trunk/src/org/openstreetmap/josm/gui/preferences/SourceEditor.java

@@ -327 +327 @@
         tblIconPaths.getColumnModel().getColumn(0).setCellEditor(new FileOrUrlCellEditor(false));
         tblIconPaths.setRowHeight(20);
-        tblIconPaths.putClientProperty("terminateEditOnFocusLost", true);
+        tblIconPaths.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         iconPathsModel.setIconPaths(getInitialIconPathsList());
 

trunk/src/org/openstreetmap/josm/gui/preferences/SourceEntry.java

@@ -90 +90 @@
      * @see #active
      */
-    public SourceEntry(String url, String name, String title, Boolean active) {
+    public SourceEntry(String url, String name, String title, boolean active) {
         this(url, false, null, name, title, active);
     }

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/ListEditor.java

@@ -69 +69 @@
         ListSettingTableModel listModel = new ListSettingTableModel();
         JTable table = new JTable(listModel);
-        table.putClientProperty("terminateEditOnFocusLost", true);
+        table.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         table.setTableHeader(null);
 

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/ListListEditor.java

@@ -102 +102 @@
         tableModel = new ListTableModel();
         table = new JTable(tableModel);
-        table.putClientProperty("terminateEditOnFocusLost", true);
+        table.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         table.setTableHeader(null);
 

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/MapListEditor.java

@@ -120 +120 @@
         tableModel = new MapTableModel();
         table = new JTable(tableModel);
-        table.putClientProperty("terminateEditOnFocusLost", true);
+        table.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         table.getTableHeader().getColumnModel().getColumn(0).setHeaderValue(tr("Key"));
         table.getTableHeader().getColumnModel().getColumn(1).setHeaderValue(tr("Value"));

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/PreferencesTable.java

@@ -53 +53 @@
         model = new AllSettingsTableModel();
         setModel(model);
-        putClientProperty("terminateEditOnFocusLost", true);
+        putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
         getColumnModel().getColumn(1).setCellRenderer(new SettingCellRenderer());
         getColumnModel().getColumn(1).setCellEditor(new SettingCellEditor());

trunk/src/org/openstreetmap/josm/gui/preferences/display/ColorPreference.java

@@ -276 +276 @@
     @Override
     public boolean ok() {
-        Boolean ret = false;
+        boolean ret = false;
         for(String d : del) {
             Main.pref.put("color."+d, null);
@@ -282 +282 @@
         for (int i = 0; i < colors.getRowCount(); ++i) {
             String key = (String)colors.getValueAt(i, 0);
-            if(Main.pref.putColor(key, (Color)colors.getValueAt(i, 1)))
-            {
+            if(Main.pref.putColor(key, (Color)colors.getValueAt(i, 1))) {
                 if(key.startsWith("mappaint.")) {
                     ret = true;

trunk/src/org/openstreetmap/josm/gui/preferences/imagery/ImageryPreference.java

@@ -302 +302 @@
                 }
             };
-            activeTable.putClientProperty("terminateEditOnFocusLost", true);
+            activeTable.putClientProperty("terminateEditOnFocusLost", Boolean.TRUE);
 
             defaultModel = new ImageryDefaultLayerTableModel();

trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginPreferencesModel.java

@@ -84 +84 @@
             if (selectedPluginsMap.get(pi) == null) {
                 if (activePlugins.contains(pi.name)) {
-                    selectedPluginsMap.put(pi, true);
+                    selectedPluginsMap.put(pi, Boolean.TRUE);
                 }
             }

trunk/src/org/openstreetmap/josm/gui/progress/AbstractProgressMonitor.java

@@ -108 +108 @@
                 requestedState.title = title;
             }
-            requestedState.intermediate = false;
+            requestedState.intermediate = Boolean.FALSE;
         } else {
             checkState(State.IN_TASK);
@@ -126 +126 @@
                 requestedState.title = title;
             }
-            requestedState.intermediate = true;
+            requestedState.intermediate = Boolean.TRUE;
         } else {
             checkState(State.IN_TASK);

trunk/src/org/openstreetmap/josm/gui/tagging/TaggingPresetItems.java

@@ -555 +555 @@
                 return null;
             case KEY:
-                return tags.containsKey(key) ? true : null;
+                return tags.containsKey(key) ? Boolean.TRUE : null;
             case KEY_REQUIRED:
                 return tags.containsKey(key);
             case KEY_VALUE:
-                return tags.containsKey(key) && getValues().contains(tags.get(key)) ? true : null;
+                return tags.containsKey(key) && getValues().contains(tags.get(key)) ? Boolean.TRUE : null;
             case KEY_VALUE_REQUIRED:
                 return tags.containsKey(key) && getValues().contains(tags.get(key));

trunk/src/org/openstreetmap/josm/gui/widgets/AbstractTextComponentValidator.java

@@ -46 +46 @@
     protected void feedbackInvalid(String msg) {
         if (valid == null || valid || !Objects.equals(msg, this.msg)) {
-            // only provide feedback if the validity has changed. This avoids
-            // unnecessary UI updates.
+            // only provide feedback if the validity has changed. This avoids unnecessary UI updates.
             tc.setBorder(ERROR_BORDER);
             tc.setBackground(ERROR_BACKGROUND);
             tc.setToolTipText(msg);
-            valid = false;
+            valid = Boolean.FALSE;
             this.msg = msg;
         }
@@ -62 +61 @@
     protected void feedbackValid(String msg) {
         if (valid == null || !valid || !Objects.equals(msg, this.msg)) {
-            // only provide feedback if the validity has changed. This avoids
-            // unnecessary UI updates.
+            // only provide feedback if the validity has changed. This avoids unnecessary UI updates.
             tc.setBorder(UIManager.getBorder("TextField.border"));
             tc.setBackground(UIManager.getColor("TextField.background"));
             tc.setToolTipText(msg == null ? "" : msg);
-            valid = true;
+            valid = Boolean.TRUE;
             this.msg = msg;
         }

trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java

@@ -184 +184 @@
         public void propertyChange(PropertyChangeEvent evt) {
             if ("editable".equals(evt.getPropertyName())) {
-                if (evt.getNewValue().equals(true)) {
+                if (evt.getNewValue().equals(Boolean.TRUE)) {
                     enableMenu();
                 } else {

trunk/src/org/openstreetmap/josm/gui/widgets/JosmEditorPane.java

@@ -125 +125 @@
             defaults.put("EditorPane[Enabled].backgroundPainter", bgColor);
             pane.putClientProperty("Nimbus.Overrides", defaults);
-            pane.putClientProperty("Nimbus.Overrides.InheritDefaults", true);
+            pane.putClientProperty("Nimbus.Overrides.InheritDefaults", Boolean.TRUE);
             pane.setBackground(bgColor);
         }

trunk/src/org/openstreetmap/josm/io/NoteReader.java

@@ -55 +55 @@
         private Action noteAction;
         private Date commentCreateDate;
-        private Boolean commentIsNew;
+        private boolean commentIsNew;
         private List<Note> notes;
         private String commentText;
@@ -119 +119 @@
                     commentIsNew = false;
                 } else {
-                    commentIsNew = Boolean.valueOf(isNew);
+                    commentIsNew = Boolean.parseBoolean(isNew);
                 }
                 break;
@@ -145 +145 @@
                 commentUsername = null;
                 commentCreateDate = null;
-                commentIsNew = null;
+                commentIsNew = false;
                 commentText = null;
             }

trunk/src/org/openstreetmap/josm/io/remotecontrol/RemoteControlHttpsServer.java

@@ -134 +134 @@
      * @param san SubjectAlternativeName extension (optional)
      */
-    private static X509Certificate generateCertificate(String dn, KeyPair pair, int days, String algorithm, String san) throws GeneralSecurityException, IOException {
+    private static X509Certificate generateCertificate(String dn, KeyPair pair, int days, String algorithm, String san)
+            throws GeneralSecurityException, IOException {
         PrivateKey privkey = pair.getPrivate();
         X509CertInfo info = new X509CertInfo();
@@ -166 +167 @@
         CertificateExtensions ext = new CertificateExtensions();
         // Critical: Not CA, max path len 0
-        ext.set(BasicConstraintsExtension.NAME, new BasicConstraintsExtension(true, false, 0));
+        ext.set(BasicConstraintsExtension.NAME, new BasicConstraintsExtension(Boolean.TRUE, false, 0));
         // Critical: only allow TLS ("serverAuth" = 1.3.6.1.5.5.7.3.1)
-        ext.set(ExtendedKeyUsageExtension.NAME, new ExtendedKeyUsageExtension(true,
+        ext.set(ExtendedKeyUsageExtension.NAME, new ExtendedKeyUsageExtension(Boolean.TRUE,
                 new Vector<ObjectIdentifier>(Arrays.asList(new ObjectIdentifier("1.3.6.1.5.5.7.3.1")))));
 
@@ -185 +186 @@
             }
             // Non critical
-            ext.set(SubjectAlternativeNameExtension.NAME, new SubjectAlternativeNameExtension(false, gnames));
+            ext.set(SubjectAlternativeNameExtension.NAME, new SubjectAlternativeNameExtension(Boolean.FALSE, gnames));
         }
 

trunk/src/org/openstreetmap/josm/tools/PlatformHookOsx.java

@@ -80 +80 @@
             Class<?> eawtFullScreenUtilities = Class.forName("com.apple.eawt.FullScreenUtilities");
             eawtFullScreenUtilities.getDeclaredMethod("setWindowCanFullScreen",
-                    new Class[]{Window.class, boolean.class}).invoke(eawtFullScreenUtilities, window, true);
+                    new Class[]{Window.class, boolean.class}).invoke(eawtFullScreenUtilities, window, Boolean.TRUE);
         } catch (ReflectiveOperationException | SecurityException | IllegalArgumentException e) {
             Main.warn("Failed to register with OSX: " + e);

trunk/src/org/openstreetmap/josm/tools/RightAndLefthandTraffic.java

@@ -29 +29 @@
             for (Area a : leftHandTrafficPolygons) {
                 if (a.contains(ll.lon(), ll.lat()))
-                    return true;
+                    return Boolean.TRUE;
             }
-            return false;
+            return Boolean.FALSE;
         }
 
@@ -40 +40 @@
                 PolygonIntersection is = Geometry.polygonIntersection(abox, a, 1e-10 /* using deg and not meters */);
                 if (is == PolygonIntersection.FIRST_INSIDE_SECOND)
-                    return true;
+                    return Boolean.TRUE;
                 if (is != PolygonIntersection.OUTSIDE)
                     return null;
             }
-            return false;
+            return Boolean.FALSE;
         }
     }