Changeset 8357 in josm for trunk/src/org/openstreetmap/josm/data/imagery

Timestamp:

2015-05-15T23:49:31+02:00 (9 years ago)

Author:

Don-vip

Message:

fix some Findbugs violations

File:

• trunk/src/org/openstreetmap/josm/data/imagery/WmsCache.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/WmsCache.java

@@ -112 +112 @@
     public WmsCache(String url, int tileSize) {
         File globalCacheDir = new File(cacheDirPath());
-        globalCacheDir.mkdirs();
+        if (!globalCacheDir.mkdirs()) {
+            Main.warn("Unable to create global cache directory: "+globalCacheDir.getAbsolutePath());
+        }
         cacheDir = new File(globalCacheDir, getCacheDirectory(url));
         cacheDir.mkdirs();
@@ -230 +232 @@
                 if (files != null) {
                     for (File file: files) {
-                        if (!referencedFiles.contains(file.getName())) {
-                            file.delete();
+                        if (!referencedFiles.contains(file.getName()) && !file.delete()) {
+                            Main.warn("Unable to delete file: "+file.getAbsolutePath());
                         }
                     }
@@ -530 +532 @@
         }
 
-        imageFile.getParentFile().mkdirs();
+        if (!imageFile.getParentFile().mkdirs()) {
+            Main.warn("Unable to create parent directory: "+imageFile.getParentFile().getAbsolutePath());
+        }
 
         if (img != null) {
@@ -555 +559 @@
                     }
                     totalFileSize -= size;
-                    file.delete();
+                    if (!file.delete()) {
+                        Main.warn("Unable to delete file: "+file.getAbsolutePath());
+                    }
                     it.remove();
                 }