Changeset 8318 in josm for trunk/src/org/openstreetmap/josm/io/remotecontrol/handler

Timestamp:

2015-05-03T18:34:33+02:00 (9 years ago)

Author:

Don-vip

Message:

fix various Sonar issues:

• squid:S1068: Unused private fields should be removed
• squid:S1155: Collection.isEmpty() should be used to test for emptiness
• squid:S1185: Overriding methods should do more than simply call the same method in the super class
• squid:S1694: An abstract class should have both abstract and concrete methods
• squid:S1905: Redundant casts should not be used
• squid:S2065: Fields in non-serializable classes should not be "transient"
• squid:S2583: Conditions should not unconditionally evaluate to "TRUE" or to "FALSE"
• squid:ModifiersOrderCheck: Modifiers should be declared in the correct order

Location:

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler

Files:

• LoadAndZoomHandler.java (modified) (1 diff)
• RequestHandler.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/LoadAndZoomHandler.java

@@ -60 +60 @@
         String msg = tr("Remote Control has been asked to load data from the API.") +
                 "<br>" + tr("Bounding box: ") + new BBox(minlon, minlat, maxlon, maxlat).toStringCSV(", ");
-        if (args.containsKey("select") && toSelect.size() > 0) {
+        if (args.containsKey("select") && !toSelect.isEmpty()) {
             msg += "<br>" + tr("Selection: {0}", toSelect.size());
         }

trunk/src/org/openstreetmap/josm/io/remotecontrol/handler/RequestHandler.java

@@ -313 +313 @@
     }
 
-    public static abstract class RawURLParseRequestHandler extends RequestHandler {
+    public abstract static class RawURLParseRequestHandler extends RequestHandler {
         @Override
         protected void parseArgs() {