Changeset 8318 in josm for trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitPane.java

Timestamp:

2015-05-03T18:34:33+02:00 (9 years ago)

Author:

Don-vip

Message:

fix various Sonar issues:

• squid:S1068: Unused private fields should be removed
• squid:S1155: Collection.isEmpty() should be used to test for emptiness
• squid:S1185: Overriding methods should do more than simply call the same method in the super class
• squid:S1694: An abstract class should have both abstract and concrete methods
• squid:S1905: Redundant casts should not be used
• squid:S2065: Fields in non-serializable classes should not be "transient"
• squid:S2583: Conditions should not unconditionally evaluate to "TRUE" or to "FALSE"
• squid:ModifiersOrderCheck: Modifiers should be declared in the correct order

File:

• trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitPane.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/widgets/MultiSplitPane.java

@@ -145 +145 @@
      * @see #setDividerPainter
      */
-    public abstract static class DividerPainter {
+    public interface DividerPainter {
         /**
          * Paint a single Divider.
@@ -155 +155 @@
     }
 
-    private class DefaultDividerPainter extends DividerPainter {
+    private class DefaultDividerPainter implements DividerPainter {
         @Override
         public void paint(Graphics g, Divider divider) {