Changeset 8318 in josm for trunk/src/org/openstreetmap/josm/gui/layer/TMSLayer.java

Timestamp:

2015-05-03T18:34:33+02:00 (9 years ago)

Author:

Don-vip

Message:

fix various Sonar issues:

• squid:S1068: Unused private fields should be removed
• squid:S1155: Collection.isEmpty() should be used to test for emptiness
• squid:S1185: Overriding methods should do more than simply call the same method in the super class
• squid:S1694: An abstract class should have both abstract and concrete methods
• squid:S1905: Redundant casts should not be used
• squid:S2065: Fields in non-serializable classes should not be "transient"
• squid:S2583: Conditions should not unconditionally evaluate to "TRUE" or to "FALSE"
• squid:ModifiersOrderCheck: Modifiers should be declared in the correct order

File:

• trunk/src/org/openstreetmap/josm/gui/layer/TMSLayer.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/layer/TMSLayer.java

@@ -1324 +1324 @@
                 continue;
             }
-            if (missedTiles.size() <= 0) {
+            if (missedTiles.isEmpty()) {
                 break;
             }
@@ -1351 +1351 @@
             missedTiles = newlyMissedTiles;
         }
-        if (Main.isDebugEnabled() && missedTiles.size() > 0) {
+        if (Main.isDebugEnabled() && !missedTiles.isEmpty()) {
             Main.debug("still missed "+missedTiles.size()+" in the end");
         }