Ignore:
Timestamp:
2015-05-03T18:34:33+02:00 (4 years ago)
Author:
Don-vip
Message:

fix various Sonar issues:

  • squid:S1068: Unused private fields should be removed
  • squid:S1155: Collection.isEmpty() should be used to test for emptiness
  • squid:S1185: Overriding methods should do more than simply call the same method in the super class
  • squid:S1694: An abstract class should have both abstract and concrete methods
  • squid:S1905: Redundant casts should not be used
  • squid:S2065: Fields in non-serializable classes should not be "transient"
  • squid:S2583: Conditions should not unconditionally evaluate to "TRUE" or to "FALSE"
  • squid:ModifiersOrderCheck: Modifiers should be declared in the correct order
File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/gui/history/TwoColumnDiff.java

    r8285 r8318  
    109109                    referenceDiff.add(new Item(DiffItemType.EMPTY, null));
    110110                    currentDiff.add(new Item(DiffItemType.INSERTED, b[ib++]));
    111                 } else if(deleted > 0) {
     111                } else {
    112112                    referenceDiff.add(new Item(DiffItemType.DELETED, a[ia++]));
    113113                    currentDiff.add(new Item(DiffItemType.EMPTY, null));
Note: See TracChangeset for help on using the changeset viewer.