Changeset 8318 in josm for trunk/src/org/openstreetmap/josm/actions/downloadtasks

Timestamp:

2015-05-03T18:34:33+02:00 (9 years ago)

Author:

Don-vip

Message:

fix various Sonar issues:

• squid:S1068: Unused private fields should be removed
• squid:S1155: Collection.isEmpty() should be used to test for emptiness
• squid:S1185: Overriding methods should do more than simply call the same method in the super class
• squid:S1694: An abstract class should have both abstract and concrete methods
• squid:S1905: Redundant casts should not be used
• squid:S2065: Fields in non-serializable classes should not be "transient"
• squid:S2583: Conditions should not unconditionally evaluate to "TRUE" or to "FALSE"
• squid:ModifiersOrderCheck: Modifiers should be declared in the correct order

Location:

trunk/src/org/openstreetmap/josm/actions/downloadtasks

Files:

• DownloadNotesTask.java (modified) (1 diff)
• DownloadNotesUrlIdTask.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadNotesTask.java

@@ -114 +114 @@
             }
             NoteLayer layer;
-            if (noteLayers != null && noteLayers.size() > 0) {
+            if (noteLayers != null && !noteLayers.isEmpty()) {
                 layer = noteLayers.get(0);
                 layer.getNoteData().addNotes(notesData);

trunk/src/org/openstreetmap/josm/actions/downloadtasks/DownloadNotesUrlIdTask.java

@@ -2 +2 @@
 package org.openstreetmap.josm.actions.downloadtasks;
 
-import org.openstreetmap.josm.gui.progress.ProgressMonitor;
+import static org.openstreetmap.josm.tools.I18n.tr;
 
 import java.util.concurrent.Future;
@@ -8 +8 @@
 import java.util.regex.Pattern;
 
-import static org.openstreetmap.josm.tools.I18n.tr;
+import org.openstreetmap.josm.gui.progress.ProgressMonitor;
 
 public class DownloadNotesUrlIdTask extends DownloadNotesTask {
@@ -29 +29 @@
     }
 
-    public boolean acceptsUrl(String url) {
-        return super.acceptsUrl(url);
-    }
-
     @Override
     public String getTitle() {