Changeset 8291 in josm for trunk/src/org/openstreetmap/josm/command

Timestamp:

2015-04-29T01:44:01+02:00 (8 years ago)

Author:

Don-vip

Message:

fix squid:RedundantThrowsDeclarationCheck + consistent Javadoc for exceptions

Location:

trunk/src/org/openstreetmap/josm/command

Files:

• Command.java (modified) (1 diff)
• DeleteCommand.java (modified) (6 diffs)

trunk/src/org/openstreetmap/josm/command/Command.java

@@ -119 +119 @@
      *
      * @param layer the data layer. Must not be null.
-     * @throws IllegalArgumentException thrown if layer is null
-     */
-    public Command(OsmDataLayer layer) throws IllegalArgumentException {
+     * @throws IllegalArgumentException if layer is null
+     */
+    public Command(OsmDataLayer layer) {
         CheckParameterUtil.ensureParameterNotNull(layer, "layer");
         this.layer = layer;

trunk/src/org/openstreetmap/josm/command/DeleteCommand.java

@@ -57 +57 @@
      *
      * @param data the primitives to delete. Must neither be null nor empty.
-     * @throws IllegalArgumentException thrown if data is null or empty
-     */
-    public DeleteCommand(Collection<? extends OsmPrimitive> data) throws IllegalArgumentException {
+     * @throws IllegalArgumentException if data is null or empty
+     */
+    public DeleteCommand(Collection<? extends OsmPrimitive> data) {
         CheckParameterUtil.ensureParameterNotNull(data, "data");
         if (data.isEmpty())
@@ -71 +71 @@
      *
      * @param data  the primitive to delete. Must not be null.
-     * @throws IllegalArgumentException thrown if data is null
-     */
-    public DeleteCommand(OsmPrimitive data) throws IllegalArgumentException {
+     * @throws IllegalArgumentException if data is null
+     */
+    public DeleteCommand(OsmPrimitive data) {
         this(Collections.singleton(data));
     }
@@ -83 +83 @@
      * @param layer the layer context for deleting this primitive. Must not be null.
      * @param data the primitive to delete. Must not be null.
-     * @throws IllegalArgumentException thrown if data is null
-     * @throws IllegalArgumentException thrown if layer is null
-     */
-    public DeleteCommand(OsmDataLayer layer, OsmPrimitive data) throws IllegalArgumentException {
+     * @throws IllegalArgumentException if data is null
+     * @throws IllegalArgumentException if layer is null
+     */
+    public DeleteCommand(OsmDataLayer layer, OsmPrimitive data) {
         this(layer, Collections.singleton(data));
     }
@@ -96 +96 @@
      * @param layer the layer context for deleting these primitives. Must not be null.
      * @param data the primitives to delete. Must neither be null nor empty.
-     * @throws IllegalArgumentException thrown if layer is null
-     * @throws IllegalArgumentException thrown if data is null or empty
-     */
-    public DeleteCommand(OsmDataLayer layer, Collection<? extends OsmPrimitive> data) throws IllegalArgumentException{
+     * @throws IllegalArgumentException if layer is null
+     * @throws IllegalArgumentException if data is null or empty
+     */
+    public DeleteCommand(OsmDataLayer layer, Collection<? extends OsmPrimitive> data) {
         super(layer);
         CheckParameterUtil.ensureParameterNotNull(data, "data");
@@ -246 +246 @@
      * @param silent  Set to true if the user should not be bugged with additional dialogs
      * @return command A command to perform the deletions, or null of there is nothing to delete.
-     * @throws IllegalArgumentException thrown if layer is null
-     */
-    public static Command deleteWithReferences(OsmDataLayer layer, Collection<? extends OsmPrimitive> selection, boolean silent) throws IllegalArgumentException {
+     * @throws IllegalArgumentException if layer is null
+     */
+    public static Command deleteWithReferences(OsmDataLayer layer, Collection<? extends OsmPrimitive> selection, boolean silent) {
         CheckParameterUtil.ensureParameterNotNull(layer, "layer");
         if (selection == null || selection.isEmpty()) return null;
@@ -271 +271 @@
      * @param selection The list of all object to be deleted.
      * @return command A command to perform the deletions, or null of there is nothing to delete.
-     * @throws IllegalArgumentException thrown if layer is null
+     * @throws IllegalArgumentException if layer is null
      */
     public static Command deleteWithReferences(OsmDataLayer layer, Collection<? extends OsmPrimitive> selection) {