Changeset 7859 in josm for trunk/src/org/openstreetmap/josm/actions/MapRectifierWMSmenuAction.java

Timestamp:

2014-12-20T16:00:06+01:00 (9 years ago)

Author:

Don-vip

Message:

fix various Sonar issues, improve Javadoc

File:

• trunk/src/org/openstreetmap/josm/actions/MapRectifierWMSmenuAction.java (modified) (4 diffs)

trunk/src/org/openstreetmap/josm/actions/MapRectifierWMSmenuAction.java

@@ -24 +24 @@
 import org.openstreetmap.josm.gui.ExtendedDialog;
 import org.openstreetmap.josm.gui.layer.WMSLayer;
+import org.openstreetmap.josm.gui.widgets.JosmTextField;
+import org.openstreetmap.josm.gui.widgets.UrlLabel;
 import org.openstreetmap.josm.tools.GBC;
 import org.openstreetmap.josm.tools.Shortcut;
 import org.openstreetmap.josm.tools.Utils;
-import org.openstreetmap.josm.gui.widgets.JosmTextField;
-import org.openstreetmap.josm.gui.widgets.UrlLabel;
-
+
+/**
+ * Download rectified images from various services.
+ * @since 3715
+ */
 public class MapRectifierWMSmenuAction extends JosmAction {
+
     /**
      * Class that bundles all required information of a rectifier service
@@ -40 +45 @@
         private final Pattern urlRegEx;
         private final Pattern idValidator;
-        public JRadioButton btn;
+        private JRadioButton btn;
 
         /**
@@ -57 +62 @@
         }
 
-        public boolean isSelected() {
+        private boolean isSelected() {
             return btn.isSelected();
         }
@@ -63 +68 @@
 
     /**
-     * List of available rectifier services. May be extended from the outside
-     */
-    public List<RectifierService> services = new ArrayList<>();
-
+     * List of available rectifier services.
+     */
+    private final List<RectifierService> services = new ArrayList<>();
+
+    /**
+     * Constructs a new {@code MapRectifierWMSmenuAction}.
+     */
     public MapRectifierWMSmenuAction() {
         super(tr("Rectified Image..."),