Changeset 7597 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2014-10-04T17:54:40+02:00 (10 years ago)

Author:

Don-vip

Message:

fix #10588 - DownloadGpsTask ignores the ProgressMonitor argument given in its constructor

File:

• trunk/src/org/openstreetmap/josm/gui/PleaseWaitRunnable.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/PleaseWaitRunnable.java

@@ -32 +32 @@
     /**
      * Create the runnable object with a given message for the user.
+     * @param title message for the user
      */
     public PleaseWaitRunnable(String title) {
         this(title, false);
     }
+
     /**
      * Create the runnable object with a given message for the user.
@@ -65 +67 @@
     }
 
+    /**
+     * Create the runnable object with a given message for the user
+     *
+     * @param title message for the user
+     * @param progressMonitor progress monitor
+     * @param ignoreException If true, exception will be propagated to calling code. If false then
+     * exception will be thrown directly in EDT. When this runnable is executed using executor framework
+     * then use false unless you read result of task (because exception will get lost if you don't)
+     * @throws IllegalArgumentException thrown if parent is null
+     */
     public PleaseWaitRunnable(String title, ProgressMonitor progressMonitor, boolean ignoreException) {
         this.title = title;
@@ -175 +187 @@
     protected abstract void finish();
 
+    /**
+     * Relies the progress monitor.
+     * @return the progress monitor
+     */
     public ProgressMonitor getProgressMonitor() {
         return progressMonitor;