Changeset 7527 in josm for trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java

Timestamp:

2014-09-11T19:27:03+02:00 (10 years ago)

Author:

Don-vip

Message:

see #10462 - more debug stuff, improve javadoc

File:

• trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java (modified) (9 diffs)

trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java

@@ -29 +29 @@
 import org.openstreetmap.josm.tools.WindowGeometry;
 
+/**
+ * Manager allowing to show/hide history dialogs.
+ * @since 2019
+ */
 public class HistoryBrowserDialogManager implements MapView.LayerChangeListener {
+
     private static HistoryBrowserDialogManager instance;
+
+    /**
+     * Replies the unique instance.
+     * @return the unique instance
+     */
     public static HistoryBrowserDialogManager getInstance() {
         if (instance == null) {
@@ -45 +55 @@
     }
 
+    /**
+     * Determines if an history dialog exists for the given object id.
+     * @param id the object id
+     * @return {@code true} if an history dialog exists for the given object id, {@code false} otherwise
+     */
     public boolean existsDialog(long id) {
         return dialogs.containsKey(id);
     }
 
-    public void show(long id, HistoryBrowserDialog dialog) {
+    protected void show(long id, HistoryBrowserDialog dialog) {
         if (dialogs.values().contains(dialog)) {
             show(id);
@@ -60 +75 @@
                 Main.debug("#10462 - JFrame.isDefaultLookAndFeelDecorated: "+JFrame.isDefaultLookAndFeelDecorated());
                 Main.debug("#10462 - dialog.isUndecorated: "+dialog.isUndecorated());
+                Main.debug("#10462 - UIManager.getLookAndFeel: "+UIManager.getLookAndFeel());
                 Main.debug("#10462 - LookAndFeel.getSupportsWindowDecorations: "+UIManager.getLookAndFeel().getSupportsWindowDecorations());
                 Main.debug("#10462 - JRootPane.getWindowDecorationStyle: "+dialog.getRootPane().getWindowDecorationStyle());
                 Main.debug("#10462 - Window.getIconImages: "+dialog.getIconImages());
                 Main.debug("#10462 - Dialog.getTitle: "+dialog.getTitle());
+                Main.debug("#10462 - Dialog.getInsets: "+dialog.getInsets());
             }
             dialogs.put(id, dialog);
@@ -69 +86 @@
     }
 
-    public void show(long id) {
+    protected void show(long id) {
         if (dialogs.keySet().contains(id)) {
             dialogs.get(id).toFront();
@@ -87 +104 @@
     final String WINDOW_GEOMETRY_PREF = getClass().getName() + ".geometry";
 
-    public void placeOnScreen(HistoryBrowserDialog dialog) {
+    protected void placeOnScreen(HistoryBrowserDialog dialog) {
         WindowGeometry geometry = new WindowGeometry(WINDOW_GEOMETRY_PREF, WindowGeometry.centerOnScreen(new Dimension(850, 500)));
         geometry.applySafe(dialog);
         Point p = dialog.getLocation();
-        while(hasDialogWithCloseUpperLeftCorner(p)) {
+        while (hasDialogWithCloseUpperLeftCorner(p)) {
             p.x += 20;
             p.y += 20;
@@ -98 +115 @@
     }
 
+    /**
+     * Hides the specified history dialog and cleans associated resources.
+     * @param dialog History dialog to hide
+     */
     public void hide(HistoryBrowserDialog dialog) {
         long id = 0;
@@ -129 +150 @@
     }
 
+    /**
+     * Show history dialog for the given history.
+     * @param h History to show
+     */
     public void show(History h) {
         if (h == null)
@@ -151 +176 @@
     public void layerRemoved(Layer oldLayer) {
         // remove all history browsers if the number of layers drops to 0
-        //
         if (Main.isDisplayingMapView() && Main.map.mapView.getNumLayers() == 0) {
             hideAll();
@@ -157 +181 @@
     }
 
+    /**
+     * Show history dialog(s) for the given primitive(s).
+     * @param primitives The primitive(s) for which history will be displayed
+     */
     public void showHistory(final Collection<? extends PrimitiveId> primitives) {
         final Collection<? extends PrimitiveId> notNewPrimitives = Utils.filter(primitives, notNewPredicate);