Changeset 7309 in josm for trunk/src/org/openstreetmap/josm/data

Timestamp:

2014-07-12T20:45:45+02:00 (10 years ago)

Author:

akks

Message:

fix #10256: incorrect "Highway link is not linked" warning for closed ways

File:

• trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/validation/tests/Highways.java

@@ -151 +151 @@
 
         final HashSet<OsmPrimitive> referrers = new HashSet<>();
-        referrers.addAll(way.firstNode().getReferrers());
-        referrers.addAll(way.lastNode().getReferrers());
+        
+        if (way.isClosed()) { 
+            // for closed way we need to check all adjacent ways
+            for (Node n: way.getNodes()) {
+                referrers.addAll(n.getReferrers());
+            }
+        } else {
+            referrers.addAll(way.firstNode().getReferrers());
+            referrers.addAll(way.lastNode().getReferrers());
+        }
 
         return Utils.exists(Utils.filteredCollection(referrers, Way.class), new Predicate<Way>() {