Changeset 6992 in josm for trunk/src/org/openstreetmap/josm/actions/mapmode

Timestamp:

2014-04-22T01:06:55+02:00 (10 years ago)

Author:

Don-vip

Message:

cleanup/refactor of NavigatableComponent

Location:

trunk/src/org/openstreetmap/josm/actions/mapmode

Files:

• ParallelWayAction.java (modified) (3 diffs)
• SelectAction.java (modified) (8 diffs)

trunk/src/org/openstreetmap/josm/actions/mapmode/ParallelWayAction.java

@@ -25 +25 @@
 import org.openstreetmap.josm.Main;
 import org.openstreetmap.josm.data.Bounds;
+import org.openstreetmap.josm.data.SystemOfMeasurement;
 import org.openstreetmap.josm.data.Preferences.PreferenceChangeEvent;
 import org.openstreetmap.josm.data.Preferences.PreferenceChangedListener;
@@ -36 +37 @@
 import org.openstreetmap.josm.gui.MapView;
 import org.openstreetmap.josm.gui.NavigatableComponent;
-import org.openstreetmap.josm.gui.NavigatableComponent.SystemOfMeasurement;
 import org.openstreetmap.josm.gui.layer.Layer;
 import org.openstreetmap.josm.gui.layer.MapViewPaintable;
@@ -429 +429 @@
             double snapDistance;
             SystemOfMeasurement som = NavigatableComponent.getSystemOfMeasurement();
-            if (som.equals(NavigatableComponent.CHINESE_SOM)) {
-                snapDistance = snapDistanceChinese * NavigatableComponent.CHINESE_SOM.aValue;
-            } else if (som.equals(NavigatableComponent.IMPERIAL_SOM)) {
-                snapDistance = snapDistanceImperial * NavigatableComponent.IMPERIAL_SOM.aValue;
-            } else if (som.equals(NavigatableComponent.NAUTICAL_MILE_SOM)) {
-                snapDistance = snapDistanceNautical * NavigatableComponent.NAUTICAL_MILE_SOM.aValue;
+            if (som.equals(SystemOfMeasurement.CHINESE)) {
+                snapDistance = snapDistanceChinese * SystemOfMeasurement.CHINESE.aValue;
+            } else if (som.equals(SystemOfMeasurement.IMPERIAL)) {
+                snapDistance = snapDistanceImperial * SystemOfMeasurement.IMPERIAL.aValue;
+            } else if (som.equals(SystemOfMeasurement.NAUTICAL_MILE)) {
+                snapDistance = snapDistanceNautical * SystemOfMeasurement.NAUTICAL_MILE.aValue;
             } else {
                 snapDistance = snapDistanceMetric; // Metric system by default

trunk/src/org/openstreetmap/josm/actions/mapmode/SelectAction.java

@@ -48 +48 @@
 import org.openstreetmap.josm.gui.MapFrame;
 import org.openstreetmap.josm.gui.MapView;
-import org.openstreetmap.josm.gui.NavigatableComponent;
 import org.openstreetmap.josm.gui.SelectionManager;
 import org.openstreetmap.josm.gui.SelectionManager.SelectionEnded;
@@ -248 +247 @@
      */
     private boolean giveUserFeedback(MouseEvent e, int modifiers) {
-        Collection<OsmPrimitive> c = MapView.asColl(
+        Collection<OsmPrimitive> c = asColl(
                 mv.getNearestNodeOrWay(e.getPoint(), OsmPrimitive.isSelectablePredicate, true));
 
@@ -431 +430 @@
             //  if nothing was selected, select primitive under cursor for scaling or rotating
             if (getCurrentDataSet().getSelected().isEmpty()) {
-                getCurrentDataSet().setSelected(MapView.asColl(nearestPrimitive));
+                getCurrentDataSet().setSelected(asColl(nearestPrimitive));
             }
 
@@ -446 +445 @@
             }
             OsmPrimitive toSelect = cycleManager.cycleSetup(nearestPrimitive, e.getPoint());
-            selectPrims(NavigatableComponent.asColl(toSelect), false, false);
+            selectPrims(asColl(toSelect), false, false);
             useLastMoveCommandIfPossible();
             // Schedule a timer to update status line "initialMoveDelay+1" ms in the future
@@ -522 +521 @@
                 needsRepaint = true;
             }
-            mv.setNewCursor(getCursor(MapView.asColl(p)), this);
+            mv.setNewCursor(getCursor(asColl(p)), this);
             // also update the stored mouse event, so we can display the correct cursor
             // when dragging a node onto another one and then press CTRL to merge
@@ -953 +952 @@
                 if (!(alt || multipleMatchesParameter)) {
                     // no real cycling, just one element in cycle list
-                    cycleList = MapView.asColl(osm);
+                    cycleList = asColl(osm);
 
                     if (waitForMouseUpParameter) {
@@ -1060 +1059 @@
             }
             // return one-element collection with one element to be selected (or added  to selection)
-            return MapView.asColl(nxt);
+            return asColl(nxt);
         }
     }
@@ -1162 +1161 @@
         }
     }
+
+    /**
+     * @return o as collection of o's type.
+     */
+    protected static <T> Collection<T> asColl(T o) {
+        if (o == null)
+            return Collections.emptySet();
+        return Collections.singleton(o);
+    }
 }