Changeset 6990 in josm for trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java

Timestamp:

2014-04-19T00:36:43+02:00 (10 years ago)

Author:

Don-vip

Message:

sonar - place Strings literals on the left side when checking for equality (can avoid NPEs)

File:

• trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/widgets/JosmComboBox.java

@@ -187 +187 @@
 
         @Override public void propertyChange(PropertyChangeEvent evt) {
-            if (evt.getPropertyName().equals("editable")) {
+            if ("editable".equals(evt.getPropertyName())) {
                 if (evt.getNewValue().equals(true)) {
                     enableMenu();
@@ -193 +193 @@
                     disableMenu();
                 }
-            } else if (evt.getPropertyName().equals("editor")) {
+            } else if ("editor".equals(evt.getPropertyName())) {
                 disableMenu();
                 if (isEditable()) {