Changeset 6990 in josm for trunk/src/org/openstreetmap/josm/data/osm

Timestamp:

2014-04-19T00:36:43+02:00 (10 years ago)

Author:

Don-vip

Message:

sonar - place Strings literals on the left side when checking for equality (can avoid NPEs)

Location:

trunk/src/org/openstreetmap/josm/data/osm

Files:

• ChangesetCache.java (modified) (2 diffs)
• TigerUtils.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/data/osm/ChangesetCache.java

@@ -175 +175 @@
     }
 
+    /**
+     * Replies the list of open changesets.
+     * @return The list of open changesets
+     */
     public List<Changeset> getOpenChangesets() {
         List<Changeset> ret = new ArrayList<Changeset>();
@@ -190 +194 @@
     @Override
     public void preferenceChanged(PreferenceChangeEvent e) {
-        if (e.getKey() == null || ! e.getKey().equals("osm-server.url"))
+        if (e.getKey() == null || !"osm-server.url".equals(e.getKey()))
             return;
 

trunk/src/org/openstreetmap/josm/data/osm/TigerUtils.java

@@ -28 +28 @@
     }
 
+    /**
+     * Determines if the given key denotes an integer value.
+     * @param name The key to determine
+     * @return {@code true} if the given key denotes an integer value
+     */
     public static boolean tagIsInt(String name) {
-        if (name.equals("tiger:tlid"))
+        if ("tiger:tlid".equals(name))
             return true;
         return false;