Changeset 6990 in josm for trunk/src/org/openstreetmap/josm/data/imagery

Timestamp:

2014-04-19T00:36:43+02:00 (10 years ago)

Author:

Don-vip

Message:

sonar - place Strings literals on the left side when checking for equality (can avoid NPEs)

File:

• trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/data/imagery/ImageryInfo.java

@@ -765 +765 @@
     public void setAttribution(AbstractTileSource s) {
         if (attributionText != null) {
-            if (attributionText.equals("osm")) {
+            if ("osm".equals(attributionText)) {
                 s.setAttributionText(new Mapnik().getAttributionText(0, null, null));
             } else {
@@ -772 +772 @@
         }
         if (attributionLinkURL != null) {
-            if (attributionLinkURL.equals("osm")) {
+            if ("osm".equals(attributionLinkURL)) {
                 s.setAttributionLinkURL(new Mapnik().getAttributionLinkURL());
             } else {
@@ -791 +791 @@
         }
         if (termsOfUseURL != null) {
-            if (termsOfUseURL.equals("osm")) {
+            if ("osm".equals(termsOfUseURL)) {
                 s.setTermsOfUseURL(new Mapnik().getTermsOfUseURL());
             } else {