Ignore:
Timestamp:
2014-04-16T02:29:53+02:00 (10 years ago)
Author:
Don-vip
Message:

sonar - fix some more issues

Location:
trunk/src/org/openstreetmap/josm/gui
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/src/org/openstreetmap/josm/gui/MenuScroller.java

    r6986 r6987  
    439439    protected void finalize() throws Throwable {
    440440        dispose();
     441        super.finalize();
    441442    }
    442443
    … …  
    566567        UP(9, 1, 9),
    567568        DOWN(1, 9, 1);
    568         static final int[] xPoints = {1, 5, 9};
     569        static final int[] XPOINTS = {1, 5, 9};
    569570        final int[] yPoints;
    570571
    … …  
    578579            Graphics g2 = g.create(size.width / 2 - 5, size.height / 2 - 5, 10, 10);
    579580            g2.setColor(Color.GRAY);
    580             g2.drawPolygon(xPoints, yPoints, 3);
     581            g2.drawPolygon(XPOINTS, yPoints, 3);
    581582            if (c.isEnabled()) {
    582583                g2.setColor(Color.BLACK);
    583                 g2.fillPolygon(xPoints, yPoints, 3);
     584                g2.fillPolygon(XPOINTS, yPoints, 3);
    584585            }
    585586            g2.dispose();

  • trunk/src/org/openstreetmap/josm/gui/help/HelpContentReader.java

    r6920 r6987  
    4343    public String fetchHelpTopicContent(String helpTopicUrl, boolean dotest) throws HelpContentReaderException {
    4444        if(helpTopicUrl == null)
    45             throw new MissingHelpContentException();
     45            throw new MissingHelpContentException(helpTopicUrl);
    4646        HttpURLConnection con = null;
    4747        BufferedReader in = null;
    … …  
    9090        }
    9191        if(dotest && s.isEmpty())
    92             throw new MissingHelpContentException();
     92            throw new MissingHelpContentException(s);
    9393        return s;
    9494    }

  • trunk/src/org/openstreetmap/josm/gui/help/HelpContentReaderException.java

    r3408 r6987  
    44public class HelpContentReaderException extends Exception {
    55    private int responseCode;
    6 
    7     public HelpContentReaderException() {
    8         super();
    9     }
    106
    117    public HelpContentReaderException(String message, Throwable cause) {
    … …  
    3935        this.responseCode = responseCode;
    4036    }
    41 
    4237}

  • trunk/src/org/openstreetmap/josm/gui/help/MissingHelpContentException.java

    r3408 r6987  
    33
    44public class MissingHelpContentException extends HelpContentReaderException {
    5 
    6     public MissingHelpContentException() {
    7         super();
    8     }
    95
    106    public MissingHelpContentException(String message, Throwable cause) {

  • trunk/src/org/openstreetmap/josm/gui/mappaint/mapcss/MapCSSException.java

    r6070 r6987  
    44public class MapCSSException extends RuntimeException {
    55
    6     protected String specialmessage;
     6    protected final String specialmessage;
    77    protected Integer line;
    88    protected Integer column;

  • trunk/src/org/openstreetmap/josm/gui/oauth/OsmOAuthAuthorizationClient.java

    r6643 r6987  
    148148        } catch(OAuthCommunicationException e){
    149149            if (canceled)
    150                 throw new OsmTransferCanceledException();
     150                throw new OsmTransferCanceledException(e);
    151151            throw new OsmOAuthAuthorizationException(e);
    152152        } catch(OAuthException e){
    153153            if (canceled)
    154                 throw new OsmTransferCanceledException();
     154                throw new OsmTransferCanceledException(e);
    155155            throw new OsmOAuthAuthorizationException(e);
    156156        } finally {
    … …  
    182182        } catch(OAuthCommunicationException e){
    183183            if (canceled)
    184                 throw new OsmTransferCanceledException();
     184                throw new OsmTransferCanceledException(e);
    185185            throw new OsmOAuthAuthorizationException(e);
    186186        } catch(OAuthException e){
    187187            if (canceled)
    188                 throw new OsmTransferCanceledException();
     188                throw new OsmTransferCanceledException(e);
    189189            throw new OsmOAuthAuthorizationException(e);
    190190        } finally {
    … …  
    569569        } catch(OsmOAuthAuthorizationException e) {
    570570            if (canceled)
    571                 throw new OsmTransferCanceledException();
     571                throw new OsmTransferCanceledException(e);
    572572            throw e;
    573573        } finally {
Note: See TracChangeset for help on using the changeset viewer.