Changeset 6977 in josm for trunk/src/org/openstreetmap/josm/gui/io/DownloadPrimitivesWithReferrersTask.java

Timestamp:

2014-04-15T00:43:24+02:00 (10 years ago)

Author:

Don-vip

Message:

fix some sonar issues recently introduced

File:

• trunk/src/org/openstreetmap/josm/gui/io/DownloadPrimitivesWithReferrersTask.java (modified) (3 diffs)

trunk/src/org/openstreetmap/josm/gui/io/DownloadPrimitivesWithReferrersTask.java

@@ -75 +75 @@
         // All downloaded primitives are put in a tmpLayer
         tmpLayer = new OsmDataLayer(new DataSet(), OsmDataLayer.createNewName(), null);
-        //Main.main.addLayer(tmpLayer);
     }
 
@@ -194 +193 @@
      * Dialog for report a problem during download.
      * @param errs Primitives involved
-     * @param TITLE Title of dialog
-     * @param TEXT Detail message
-     * @param LIST_LABEL List of primitives description
-     * @param msgType Type of message {@see JOptionPane}
+     * @param title Title of dialog
+     * @param text Detail message
+     * @param listLabel List of primitives description
+     * @param msgType Type of message, see {@link JOptionPane}
      * @return The Dialog object
      */
     private static ExtendedDialog reportProblemDialog(Set<PrimitiveId> errs,
-            String TITLE, String TEXT, String LIST_LABEL, int msgType) {
+            String title, String text, String listLabel, int msgType) {
         JPanel p = new JPanel(new GridBagLayout());
-        p.add(new HtmlPanel(TEXT), GBC.eop());
-        if (LIST_LABEL != null) {
-            JLabel missing = new JLabel(LIST_LABEL);
+        p.add(new HtmlPanel(text), GBC.eop());
+        if (listLabel != null) {
+            JLabel missing = new JLabel(listLabel);
             missing.setFont(missing.getFont().deriveFont(Font.PLAIN));
             p.add(missing, GBC.eol());
@@ -221 +220 @@
         return new ExtendedDialog(
                 Main.parent,
-                TITLE,
+                title,
                 new String[] { tr("Ok") })
         .setButtonIcons(new String[] { "ok" })