Changeset 6890 in josm for trunk/src/org/openstreetmap/josm/gui/mappaint/xml

Timestamp:

2014-02-27T02:50:12+01:00 (10 years ago)

Author:

Don-vip

Message:

fix some Sonar issues (Constructor Calls Overridable Method)

Location:

trunk/src/org/openstreetmap/josm/gui/mappaint/xml

Files:

• AreaPrototype.java (modified) (1 diff)
• IconPrototype.java (modified) (1 diff)
• LinemodPrototype.java (modified) (2 diffs)
• XmlCondition.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/AreaPrototype.java

@@ -20 +20 @@
     public AreaPrototype() { init(); }
 
-    public void init()
-    {
+    public final void init() {
         priority = 0;
         range = Range.ZERO_TO_INFINITY;

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/IconPrototype.java

@@ -20 +20 @@
     public IconPrototype() { init(); }
 
-    public void init() {
+    public final void init() {
         priority = 0;
         range = Range.ZERO_TO_INFINITY;

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/LinemodPrototype.java

@@ -20 +20 @@
 
     @Override
-    public void init()
-    {
+    public final void init() {
         super.init();
         over = true;
@@ -27 +26 @@
     }
 
-    // get width for overlays
-    public float getWidth(float ref)
-    {
+    /** get width for overlays */
+    public float getWidth(float ref) {
         float res;
         if(widthMode == WidthMode.ABSOLUTE) {

trunk/src/org/openstreetmap/josm/gui/mappaint/xml/XmlCondition.java

@@ -10 +10 @@
     public String boolValue;
 
-    public XmlCondition()
-    {
+    public XmlCondition() {
       init();
     }
-    public XmlCondition(XmlCondition c)
-    {
+
+    public XmlCondition(XmlCondition c) {
       key = c.key;
       value = c.value;
       boolValue = c.boolValue;
     }
-    public String getKey()
-    {
+
+    public String getKey() {
         if(value != null)
             return "n" + key + "=" + value;
@@ -29 +28 @@
             return "x" + key;
     }
-    public void init()
-    {
+
+    public final void init() {
       key = value = boolValue = null;
     }
 
-    public String toString()
-    {
+    public String toString() {
       return "Rule["+key+","+(boolValue != null ? "b="+boolValue:"v="+value)+"]";
     }
 
-    public void appendCode(StringBuilder sb)
-    {
+    public void appendCode(StringBuilder sb) {
         sb.append("[k=").append(key);