Ignore:
Timestamp:
2014-02-27T02:50:12+01:00 (6 years ago)
Author:
Don-vip
Message:

fix some Sonar issues (Constructor Calls Overridable Method)

Location:
trunk/src/org/openstreetmap/josm/command
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/command/MoveCommand.java

    r6881 r6890  
    153153     * Save curent displacement to restore in case of some problems
    154154     */
    155     public void saveCheckpoint() {
     155    public final void saveCheckpoint() {
    156156        backupX = x;
    157157        backupY = y;
  • trunk/src/org/openstreetmap/josm/command/PurgeCommand.java

    r6883 r6890  
    6767    }
    6868
    69     protected void saveIncomplete(Collection<OsmPrimitive> makeIncomplete) {
     69    protected final void saveIncomplete(Collection<OsmPrimitive> makeIncomplete) {
    7070        makeIncompleteData = new Storage<PrimitiveData>(new Storage.PrimitiveIdHash());
    7171        makeIncompleteData_byPrimId = makeIncompleteData.foreignKey(new Storage.PrimitiveIdHash());
  • trunk/src/org/openstreetmap/josm/command/RotateCommand.java

    r6830 r6890  
    5252     * Get angle between the horizontal axis and the line formed by the pivot and give points.
    5353     **/
    54     protected double getAngle(EastNorth currentEN) {
     54    protected final double getAngle(EastNorth currentEN) {
    5555        if ( pivot == null )
    5656            return 0.0; // should never happen by contract
     
    6262     */
    6363    @Override
    64     public void handleEvent(EastNorth currentEN) {
     64    public final void handleEvent(EastNorth currentEN) {
    6565        double currentAngle = getAngle(currentEN);
    6666        rotationAngle = currentAngle - startAngle;
  • trunk/src/org/openstreetmap/josm/command/ScaleCommand.java

    r6296 r6890  
    5454     */
    5555    @Override
    56     public void handleEvent(EastNorth currentEN) {
     56    public final void handleEvent(EastNorth currentEN) {
    5757        double startAngle = Math.atan2(startEN.east()-pivot.east(), startEN.north()-pivot.north());
    5858        double endAngle = Math.atan2(currentEN.east()-pivot.east(), currentEN.north()-pivot.north());
     
    6262        transformNodes();
    6363    }
    64 
    6564
    6665    /**
  • trunk/src/org/openstreetmap/josm/command/TransformNodesCommand.java

    r6830 r6890  
    3838     * Stores the state of the nodes before the command.
    3939     */
    40     protected void storeOldState() {
     40    protected final void storeOldState() {
    4141        for (Node n : this.nodes) {
    4242            oldStates.put(n, new OldNodeState(n));
Note: See TracChangeset for help on using the changeset viewer.