Changeset 6890 in josm for trunk/src/org/openstreetmap/josm/command

Timestamp:

2014-02-27T02:50:12+01:00 (10 years ago)

Author:

Don-vip

Message:

fix some Sonar issues (Constructor Calls Overridable Method)

Location:

trunk/src/org/openstreetmap/josm/command

Files:

• MoveCommand.java (modified) (1 diff)
• PurgeCommand.java (modified) (1 diff)
• RotateCommand.java (modified) (2 diffs)
• ScaleCommand.java (modified) (2 diffs)
• TransformNodesCommand.java (modified) (1 diff)

trunk/src/org/openstreetmap/josm/command/MoveCommand.java

@@ -153 +153 @@
      * Save curent displacement to restore in case of some problems
      */
-    public void saveCheckpoint() {
+    public final void saveCheckpoint() {
         backupX = x;
         backupY = y;

trunk/src/org/openstreetmap/josm/command/PurgeCommand.java

@@ -67 +67 @@
     }
 
-    protected void saveIncomplete(Collection<OsmPrimitive> makeIncomplete) {
+    protected final void saveIncomplete(Collection<OsmPrimitive> makeIncomplete) {
         makeIncompleteData = new Storage<PrimitiveData>(new Storage.PrimitiveIdHash());
         makeIncompleteData_byPrimId = makeIncompleteData.foreignKey(new Storage.PrimitiveIdHash());

trunk/src/org/openstreetmap/josm/command/RotateCommand.java

@@ -52 +52 @@
      * Get angle between the horizontal axis and the line formed by the pivot and give points.
      **/
-    protected double getAngle(EastNorth currentEN) {
+    protected final double getAngle(EastNorth currentEN) {
         if ( pivot == null )
             return 0.0; // should never happen by contract
@@ -62 +62 @@
      */
     @Override
-    public void handleEvent(EastNorth currentEN) {
+    public final void handleEvent(EastNorth currentEN) {
         double currentAngle = getAngle(currentEN);
         rotationAngle = currentAngle - startAngle;

trunk/src/org/openstreetmap/josm/command/ScaleCommand.java

@@ -54 +54 @@
      */
     @Override
-    public void handleEvent(EastNorth currentEN) {
+    public final void handleEvent(EastNorth currentEN) {
         double startAngle = Math.atan2(startEN.east()-pivot.east(), startEN.north()-pivot.north());
         double endAngle = Math.atan2(currentEN.east()-pivot.east(), currentEN.north()-pivot.north());
@@ -62 +62 @@
         transformNodes();
     }
-
 
     /**

trunk/src/org/openstreetmap/josm/command/TransformNodesCommand.java

@@ -38 +38 @@
      * Stores the state of the nodes before the command.
      */
-    protected void storeOldState() {
+    protected final void storeOldState() {
         for (Node n : this.nodes) {
             oldStates.put(n, new OldNodeState(n));