Ignore:
Timestamp:
2014-02-25T01:31:24+01:00 (5 years ago)
Author:
Don-vip
Message:

fix some Sonar issues

Location:
trunk/src/org/openstreetmap/josm/gui/history
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/org/openstreetmap/josm/gui/history/CoordinateInfoViewer.java

    r6105 r6883  
    2929
    3030    /** background color used when the coordinates are different */
    31     public final static Color BGCOLOR_DIFFERENCE = new Color(255,197,197);
     31    public static final Color BGCOLOR_DIFFERENCE = new Color(255,197,197);
    3232
    3333    /** the model */
  • trunk/src/org/openstreetmap/josm/gui/history/HistoryBrowserDialogManager.java

    r6743 r6883  
    2727
    2828public class HistoryBrowserDialogManager implements MapView.LayerChangeListener {
    29     static private HistoryBrowserDialogManager instance;
    30     static public HistoryBrowserDialogManager getInstance() {
     29    private static HistoryBrowserDialogManager instance;
     30    public static HistoryBrowserDialogManager getInstance() {
    3131        if (instance == null) {
    3232            instance = new HistoryBrowserDialogManager();
  • trunk/src/org/openstreetmap/josm/gui/history/NodeListTableCellRenderer.java

    r6084 r6883  
    1717public class NodeListTableCellRenderer extends JLabel implements TableCellRenderer {
    1818
    19     public final static Color BGCOLOR_SELECTED = new Color(143,170,255);
     19    public static final Color BGCOLOR_SELECTED = new Color(143,170,255);
    2020
    2121    private ImageIcon nodeIcon;
    2222
     23    /**
     24     * Constructs a new {@code NodeListTableCellRenderer}.
     25     */
    2326    public NodeListTableCellRenderer(){
    2427        setOpaque(true);
  • trunk/src/org/openstreetmap/josm/gui/history/NodeListViewer.java

    r6792 r6883  
    280280    }
    281281
    282     static private PrimitiveId primitiveIdAtRow(TableModel model, int row) {
     282    private static PrimitiveId primitiveIdAtRow(TableModel model, int row) {
    283283        DiffTableModel castedModel = (DiffTableModel) model;
    284284        Long id = (Long)castedModel.getValueAt(row, 0).value;
  • trunk/src/org/openstreetmap/josm/gui/history/RelationMemberListTableCellRenderer.java

    r6316 r6883  
    2626public class RelationMemberListTableCellRenderer extends JLabel implements TableCellRenderer {
    2727
    28     public final static Color BGCOLOR_EMPTY_ROW = new Color(234,234,234);
    29     public final static Color BGCOLOR_NOT_IN_OPPOSITE = new Color(255,197,197);
    30     public final static Color BGCOLOR_IN_OPPOSITE = new Color(255,234,213);
    31     public final static Color BGCOLOR_SELECTED = new Color(143,170,255);
     28    public static final Color BGCOLOR_EMPTY_ROW = new Color(234,234,234);
     29    public static final Color BGCOLOR_NOT_IN_OPPOSITE = new Color(255,197,197);
     30    public static final Color BGCOLOR_IN_OPPOSITE = new Color(255,234,213);
     31    public static final Color BGCOLOR_SELECTED = new Color(143,170,255);
    3232
    3333    private Map<OsmPrimitiveType, ImageIcon> icons;
    3434
    35     public RelationMemberListTableCellRenderer(){
     35    /**
     36     * Constructs a new {@code RelationMemberListTableCellRenderer}.
     37     */
     38    public RelationMemberListTableCellRenderer() {
    3639        setOpaque(true);
    3740        icons = new HashMap<OsmPrimitiveType, ImageIcon>();
  • trunk/src/org/openstreetmap/josm/gui/history/TagTableCellRenderer.java

    r6084 r6883  
    1818 */
    1919public class TagTableCellRenderer extends JLabel implements TableCellRenderer {
    20     public final static Color BGCOLOR_DIFFERENCE = new Color(255,197,197);
     20    public static final Color BGCOLOR_DIFFERENCE = new Color(255,197,197);
    2121
     22    /**
     23     * Constructs a new {@code TagTableCellRenderer}.
     24     */
    2225    public TagTableCellRenderer() {
    2326        setOpaque(true);
Note: See TracChangeset for help on using the changeset viewer.