Context Navigation

Changeset 6822 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2014-02-07T01:03:57+01:00 (10 years ago)

Author:

bastiK

Message:

see #8902 - Small performance enhancements / coding style (patch by shinigami, updated, modified)

stringbuilder.diff: StringBuffer => StringBuilder

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

r6793	r6822
652	652	@Override
653	653	public String toString() {
654		StringBu~~ffer sb = new StringBuff~~er();
	654	StringBuilder sb = new StringBuilder();
655	655	sb.append("min=").append(min.x).append(",").append(min.y).append(",");
656	656	sb.append("max=").append(max.x).append(",").append(max.y).append(",");

r6524	r6822
356	356	items.add(tr("{0} more...", deletedIds.size() - MAX_DELETED_PRIMITIVE_IN_DIALOG));
357	357	}
358		StringBu~~ffer sb = new StringBuff~~er();
	358	StringBuilder sb = new StringBuilder();
359	359	sb.append("<html>");
360	360	sb.append(tr("The following objects could not be copied to the target object<br>because they are deleted in the target dataset:"));

r6555	r6822
486	486	);
487	487
488		final StringBu~~ffer sb = new StringBuff~~er();
	488	final StringBuilder sb = new StringBuilder();
489	489	sb.append("<html>").append(msg1).append("</html>");
490	490	if (numNewConflicts > 0) {

r6742	r6822
715	715	}
716	716	}
717		StringBu~~ffer text = new StringBuff~~er();
	717	StringBuilder text = new StringBuilder();
718	718	if(ways != 0) {
719	719	text.append(text.length() > 0 ? ", " : "")

r6084	r6822
32	32
33	33	protected void renderLabel(Changeset cs) {
34		StringBu~~ffer sb = new StringBuff~~er();
	34	StringBuilder sb = new StringBuilder();
35	35	if (cs.isIncomplete()) {
36	36	sb.append(tr("{0} [incomplete]", cs.getId()));

r6552	r6822
277	277	protected String buildToolTipText(Bookmark b) {
278	278	Bounds area = b.getArea();
279		StringBu~~ffer sb = new StringBuff~~er();
	279	StringBuilder sb = new StringBuilder();
280	280	sb.append("<html>min[latitude,longitude]=<strong>[")
281	281	.append(area.getMinLat()).append(",").append(area.getMinLon()).append("]</strong>")

-              r6643
+              r6822
         protected String lineWrapDescription(String description) {
             StringBuffer ret = new StringBuffer();
             StringBuffer line = new StringBuffer();
+            StringBuilder ret = new StringBuilder();
+            StringBuilder line = new StringBuilder();
             StringTokenizer tok = new StringTokenizer(description, " ");
             while(tok.hasMoreElements()) {
 …
                     line.append(" ").append(t).append("<br>");
                     ret.append(line);
                     line = new StringBuffer();
+                    line = new StringBuilder();
+                }
+            }

r6800	r6822
140	140	)
141	141	);
142		StringBu~~ffer css = new StringBuff~~er();
	142	StringBuilder css = new StringBuilder();
143	143	try {
144	144	String line = null;

r6084	r6822
54	54	if (cs != null) {
55	55	setIcon(icon);
56		StringBu~~ffer sb = new StringBuff~~er();
	56	StringBuilder sb = new StringBuilder();
57	57	if (cs.get("comment") != null) {
58	58	sb.append(cs.getId()).append(" - ").append(cs.get("comment"));

-              r6654
+              r6822
     protected String buildChangesetSummary() {
         StringBuffer msg = new StringBuffer();
+        StringBuilder msg = new StringBuilder();
         if (selectedChangeset == null || selectedChangeset.isNew()) {
             msg.append(tr("Objects are uploaded to a <strong>new changeset</strong>."));
 …
     protected void updateSummary() {
         StringBuffer sb = new StringBuffer();
+        StringBuilder sb = new StringBuilder();
         sb.append("<html>");
         sb.append(buildStrategySummary());

-              r6798
+              r6822
                 TimeZone tz = TimeZone.getTimeZone(tzStr);
                 String tzDesc = new StringBuffer(tzStr).append(" (")
+                String tzDesc = new StringBuilder(tzStr).append(" (")
                 .append(formatTimezone(tz.getRawOffset() / 3600000.0))
                 .append(')').toString();
 …
+            }
             cbTimezones.setSelectedItem(new StringBuffer(defaultTz.getID()).append(" (")
+            cbTimezones.setSelectedItem(new StringBuilder(defaultTz.getID()).append(" (")
                     .append(formatTimezone(defaultTz.getRawOffset() / 3600000.0))
                     .append(')').toString());
 …
     private String formatTimezone(double timezone) {
         StringBuffer ret = new StringBuffer();
+        StringBuilder ret = new StringBuilder();
         if (timezone < 0) {
 …
         char sgnTimezone = '+';
         StringBuffer hTimezone = new StringBuffer();
         StringBuffer mTimezone = new StringBuffer();
+        StringBuilder hTimezone = new StringBuilder();
+        StringBuilder mTimezone = new StringBuilder();
         int state = 1; // 1=start/sign, 2=hours, 3=minutes.
         for (int i = 0; i < timezone.length(); i++) {

r6456	r6822
253	253	}
254	254	setTitle("Geotagged Images" + (entry.getFile() != null ? " - " + entry.getFile().getName() : ""));
255		StringBu~~ffer osd = new StringBuff~~er(entry.getFile() != null ? entry.getFile().getName() : "");
	255	StringBuilder osd = new StringBuilder(entry.getFile() != null ? entry.getFile().getName() : "");
256	256	if (entry.getElevation() != null) {
257	257	osd.append(tr("\nAltitude: {0} m", entry.getElevation().longValue()));

Note: See TracChangeset for help on using the changeset viewer.