Changeset 6603 in josm for trunk/src/org/openstreetmap/josm/gui

Timestamp:

2014-01-03T04:51:04+01:00 (10 years ago)

Author:

Don-vip

Message:

fix some Sonar issues

Location:

trunk/src/org/openstreetmap/josm/gui

Files:

• bbox/SourceButton.java (modified) (6 diffs)
• dialogs/changeset/ChangesetCacheManager.java (modified) (6 diffs)
• dialogs/changeset/ChangesetContentPanel.java (modified) (15 diffs)
• dialogs/changeset/ChangesetDetailPanel.java (modified) (15 diffs)
• dialogs/changeset/SingleChangesetDownloadPanel.java (modified) (2 diffs)
• mappaint/LabelCompositionStrategy.java (modified) (2 diffs)
• preferences/advanced/PreferencesTable.java (modified) (2 diffs)
• preferences/plugin/PluginPreference.java (modified) (3 diffs)
• widgets/EditableList.java (modified) (2 diffs)

trunk/src/org/openstreetmap/josm/gui/bbox/SourceButton.java

@@ -24 +24 @@
 public class SourceButton extends JComponent {
 
-    private final int layerHeight = 20;
-    private final int leftPadding = 5;
-    private final int topPadding = 5;
-    private final int bottomPadding = 5;
-
+    private static final int LAYER_HEIGHT = 20;
+    private static final int LEFT_PADDING = 5;
+    private static final int TOP_PADDING = 5;
+    private static final int BOTTOM_PADDING = 5;
 
     private TileSource[] sources;
@@ -47 +46 @@
 
     public SourceButton(SlippyMapBBoxChooser slippyMapBBoxChooser, Collection<TileSource> sources) {
-        super();
         this.slippyMapBBoxChooser = slippyMapBBoxChooser;
         setSources(sources);
@@ -68 +66 @@
                         toggle();
                     } else {
-                        int result = (point.y - 5) / layerHeight;
+                        int result = (point.y - 5) / LAYER_HEIGHT;
                         if (result >= 0 && result < SourceButton.this.sources.length) {
                             SourceButton.this.slippyMapBBoxChooser.toggleMapSource(SourceButton.this.sources[result]);
@@ -78 +76 @@
                     toggle();
                 }
-
             }
         }
@@ -105 +102 @@
 
                 g.setColor(new Color(0, 0, 139, 179));
-                g.fillRoundRect(0, 0, barWidth + shrinkImage.getIconWidth(), sources.length * layerHeight + topPadding + bottomPadding, 10, 10);
+                g.fillRoundRect(0, 0, barWidth + shrinkImage.getIconWidth(), sources.length * LAYER_HEIGHT + TOP_PADDING + BOTTOM_PADDING, 10, 10);
                 for (int i=0; i<sources.length; i++) {
                     g.setColor(Color.WHITE);
-                    g.fillOval(leftPadding, topPadding + i * layerHeight + 6, radioButtonSize, radioButtonSize);
-                    g.drawString(sources[i].getName(), leftPadding + radioButtonSize + leftPadding, topPadding + i * layerHeight + g.getFontMetrics().getHeight());
+                    g.fillOval(LEFT_PADDING, TOP_PADDING + i * LAYER_HEIGHT + 6, radioButtonSize, radioButtonSize);
+                    g.drawString(sources[i].getName(), LEFT_PADDING + radioButtonSize + LEFT_PADDING, TOP_PADDING + i * LAYER_HEIGHT + g.getFontMetrics().getHeight());
                     if (currentMap == i) {
                         g.setColor(Color.BLACK);
-                        g.fillOval(leftPadding + 1, topPadding + 7 + i * layerHeight, radioButtonSize - 2, radioButtonSize - 2);
+                        g.fillOval(LEFT_PADDING + 1, TOP_PADDING + 7 + i * LAYER_HEIGHT, radioButtonSize - 2, radioButtonSize - 2);
                     }
                 }
@@ -155 +152 @@
             }
             barWidth = textWidth + 50;
-            shownDimension = new Dimension(barWidth + shrinkImage.getIconWidth(), sources.length * layerHeight + topPadding + bottomPadding);
+            shownDimension = new Dimension(barWidth + shrinkImage.getIconWidth(), sources.length * LAYER_HEIGHT + TOP_PADDING + BOTTOM_PADDING);
         }
     }

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetCacheManager.java

@@ -20 +20 @@
 import javax.swing.AbstractAction;
 import javax.swing.DefaultListSelectionModel;
+import javax.swing.ImageIcon;
 import javax.swing.JComponent;
 import javax.swing.JFrame;
@@ -61 +62 @@
 public class ChangesetCacheManager extends JFrame {
 
+    /** The changeset download icon **/
+    public static final ImageIcon DOWNLOAD_CONTENT_ICON = ImageProvider.get("dialogs/changeset", "downloadchangesetcontent");
+    /** The changeset update icon **/
+    public static final ImageIcon UPDATE_CONTENT_ICON   = ImageProvider.get("dialogs/changeset", "updatechangesetcontent");
+
     /** the unique instance of the cache manager  */
     private static ChangesetCacheManager instance;
@@ -160 +166 @@
 
         // -- add the details panel
-        ChangesetDetailPanel pnlChangesetDetail;
-        tp.add(pnlChangesetDetail = new ChangesetDetailPanel());
+        ChangesetDetailPanel pnlChangesetDetail = new ChangesetDetailPanel();
+        tp.add(pnlChangesetDetail);
         model.addPropertyChangeListener(pnlChangesetDetail);
 
@@ -284 +290 @@
     }
 
+    /**
+     * Constructs a new {@code ChangesetCacheManager}.
+     */
     public ChangesetCacheManager() {
         build();
@@ -483 +492 @@
         public DownloadSelectedChangesetContentAction() {
             putValue(NAME, tr("Download changeset content"));
-            putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset", "downloadchangesetcontent"));
+            putValue(SMALL_ICON, DOWNLOAD_CONTENT_ICON);
             putValue(SHORT_DESCRIPTION, tr("Download the content of the selected changesets from the server"));
             updateEnabledState();
@@ -627 +636 @@
     }
 
+    /**
+     * Runs the given changeset download task.
+     * @param task The changeset download task to run
+     */
     public void runDownloadTask(final ChangesetDownloadTask task) {
         Main.worker.submit(task);
-        Runnable r = new Runnable() {
-            @Override public void run() {
+        Main.worker.submit(new Runnable() {
+            @Override
+            public void run() {
                 if (task.isCanceled() || task.isFailed()) return;
                 setSelectedChangesets(task.getDownloadedChangesets());
             }
-        };
-        Main.worker.submit(r);
+        });
     }
 }

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetContentPanel.java

@@ -59 +59 @@
  *
  */
-public class ChangesetContentPanel extends JPanel implements PropertyChangeListener{
+public class ChangesetContentPanel extends JPanel implements PropertyChangeListener {
 
     private ChangesetContentTableModel model;
     private Changeset currentChangeset;
 
-    private DonwloadChangesetContentAction actDownloadContentAction;
+    private DownloadChangesetContentAction actDownloadContentAction;
     private ShowHistoryAction actShowHistory;
     private SelectInCurrentLayerAction actSelectInCurrentLayerAction;
     private ZoomInCurrentLayerAction actZoomInCurrentLayerAction;
 
-    private HeaderPanel pnlHeader;
+    private final HeaderPanel pnlHeader = new HeaderPanel();
 
     protected void buildModels() {
         DefaultListSelectionModel selectionModel =new DefaultListSelectionModel();
         model = new ChangesetContentTableModel(selectionModel);
-        actDownloadContentAction = new DonwloadChangesetContentAction();
+        actDownloadContentAction = new DownloadChangesetContentAction();
         actDownloadContentAction.initProperties(currentChangeset);
         actShowHistory = new ShowHistoryAction();
@@ -126 +126 @@
     }
 
-    protected void build() {
+    protected final void build() {
         setBorder(BorderFactory.createEmptyBorder(5,5,5,5));
         setLayout(new BorderLayout());
         buildModels();
 
-        add(pnlHeader = new HeaderPanel(), BorderLayout.NORTH);
+        add(pnlHeader, BorderLayout.NORTH);
         add(buildActionButtonPanel(), BorderLayout.WEST);
         add(buildContentPanel(), BorderLayout.CENTER);
-
     }
 
@@ -173 +172 @@
         setCurrentChangeset(cs);
     }
+    
+    private final void alertNoPrimitivesTo(Collection<HistoryOsmPrimitive> primitives, String title, String helpTopic) {
+        HelpAwareOptionPane.showOptionDialog(
+                ChangesetContentPanel.this,
+                trn("<html>The selected object is not available in the current<br>"
+                        + "edit layer ''{0}''.</html>",
+                        "<html>None of the selected objects is available in the current<br>"
+                        + "edit layer ''{0}''.</html>",
+                        primitives.size(),
+                        Main.main.getEditLayer().getName()
+                ),
+                title, JOptionPane.WARNING_MESSAGE, helpTopic
+        );
+    }
 
     /**
@@ -178 +191 @@
      *
      */
-    class DonwloadChangesetContentAction extends AbstractAction{
-        public DonwloadChangesetContentAction() {
+    class DownloadChangesetContentAction extends AbstractAction{
+        public DownloadChangesetContentAction() {
             putValue(NAME, tr("Download content"));
-            putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset","downloadchangesetcontent"));
+            putValue(SMALL_ICON, ChangesetCacheManager.DOWNLOAD_CONTENT_ICON);
             putValue(SHORT_DESCRIPTION, tr("Download the changeset content from the OSM server"));
         }
@@ -201 +214 @@
             if (cs.getContent() == null) {
                 putValue(NAME, tr("Download content"));
-                putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset","downloadchangesetcontent"));
+                putValue(SMALL_ICON, ChangesetCacheManager.DOWNLOAD_CONTENT_ICON);
                 putValue(SHORT_DESCRIPTION, tr("Download the changeset content from the OSM server"));
             } else {
                 putValue(NAME, tr("Update content"));
-                putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset","updatechangesetcontent"));
+                putValue(SMALL_ICON, ChangesetCacheManager.UPDATE_CONTENT_ICON);
                 putValue(SHORT_DESCRIPTION, tr("Update the changeset content from the OSM server"));
             }
@@ -221 +234 @@
     }
 
-    class ShowHistoryAction extends AbstractAction implements ListSelectionListener{
+    class ShowHistoryAction extends AbstractAction implements ListSelectionListener {
+        
+        private final class ShowHistoryTask implements Runnable {
+            private final Collection<HistoryOsmPrimitive> primitives;
+
+            private ShowHistoryTask(Collection<HistoryOsmPrimitive> primitives) {
+                this.primitives = primitives;
+            }
+
+            @Override
+            public void run() {
+                try {
+                    for (HistoryOsmPrimitive p : primitives) {
+                        final History h = HistoryDataSet.getInstance().getHistory(p.getPrimitiveId());
+                        if (h == null) {
+                            continue;
+                        }
+                        GuiHelper.runInEDT(new Runnable() {
+                            @Override
+                            public void run() {
+                                HistoryBrowserDialogManager.getInstance().show(h);
+                            }
+                        });
+                    }
+                } catch (final Exception e) {
+                    GuiHelper.runInEDT(new Runnable() {
+                        @Override
+                        public void run() {
+                            BugReportExceptionHandler.handleException(e);
+                        }
+                    });
+                }
+            }
+        }
+
         public ShowHistoryAction() {
             putValue(NAME, tr("Show history"));
@@ -250 +297 @@
             }
 
-            Runnable r = new Runnable() {
-                @Override
-                public void run() {
-                    try {
-                        for (HistoryOsmPrimitive p : primitives) {
-                            final History h = HistoryDataSet.getInstance().getHistory(p.getPrimitiveId());
-                            if (h == null) {
-                                continue;
-                            }
-                            GuiHelper.runInEDT(new Runnable() {
-                                @Override public void run() {
-                                    HistoryBrowserDialogManager.getInstance().show(h);
-                                }
-                            });
-                        }
-                    } catch (final Exception e) {
-                        GuiHelper.runInEDT(new Runnable() {
-                            @Override
-                            public void run() {
-                                BugReportExceptionHandler.handleException(e);
-                            }
-                        });
-                    }
-
-                }
-            };
-            Main.worker.submit(r);
-        }
-
-        protected void updateEnabledState() {
+            Main.worker.submit(new ShowHistoryTask(primitives));
+        }
+
+        protected final void updateEnabledState() {
             setEnabled(model.hasSelectedPrimitives());
         }
@@ -303 +324 @@
             putValue(SHORT_DESCRIPTION, tr("Select the corresponding primitives in the current data layer"));
             updateEnabledState();
-        }
-
-        protected void alertNoPrimitivesToSelect(Collection<HistoryOsmPrimitive> primitives) {
-            HelpAwareOptionPane.showOptionDialog(
-                    ChangesetContentPanel.this,
-                    trn("<html>The selected object is not available in the current<br>"
-                            + "edit layer ''{0}''.</html>",
-                            "<html>None of the selected objects is available in the current<br>"
-                            + "edit layer ''{0}''.</html>",
-                            primitives.size(),
-                            Main.main.getEditLayer().getName()
-                    ),
-                    tr("Nothing to select"),
-                    JOptionPane.WARNING_MESSAGE,
-                    HelpUtil.ht("/Dialog/ChangesetCacheManager#NothingToSelectInLayer")
-            );
         }
 
@@ -336 +341 @@
             }
             if (target.isEmpty()) {
-                alertNoPrimitivesToSelect(selected);
+                alertNoPrimitivesTo(selected, tr("Nothing to select"), 
+                        HelpUtil.ht("/Dialog/ChangesetCacheManager#NothingToSelectInLayer"));
                 return;
             }
@@ -342 +348 @@
         }
 
-        public void updateEnabledState() {
+        public final void updateEnabledState() {
             if (Main.main == null || !Main.main.hasEditLayer()) {
                 setEnabled(false);
@@ -368 +374 @@
             putValue(SHORT_DESCRIPTION, tr("Zoom to the corresponding objects in the current data layer"));
             updateEnabledState();
-        }
-
-        protected void alertNoPrimitivesToZoomTo(Collection<HistoryOsmPrimitive> primitives) {
-            HelpAwareOptionPane.showOptionDialog(
-                    ChangesetContentPanel.this,
-                    trn("<html>The selected object is not available in the current<br>"
-                            + "edit layer ''{0}''.</html>",
-                            "<html>None of the selected objects is available in the current<br>"
-                            + "edit layer ''{0}''.</html>",
-                            primitives.size(),
-                            Main.main.getEditLayer().getName()
-                    ),
-                    tr("Nothing to zoom to"),
-                    JOptionPane.WARNING_MESSAGE,
-                    HelpUtil.ht("/Dialog/ChangesetCacheManager#NothingToZoomTo")
-            );
         }
 
@@ -401 +391 @@
             }
             if (target.isEmpty()) {
-                alertNoPrimitivesToZoomTo(selected);
+                alertNoPrimitivesTo(selected, tr("Nothing to zoom to"), 
+                        HelpUtil.ht("/Dialog/ChangesetCacheManager#NothingToZoomTo"));
                 return;
             }
@@ -408 +399 @@
         }
 
-        public void updateEnabledState() {
+        public final void updateEnabledState() {
             if (Main.main == null || !Main.main.hasEditLayer()) {
                 setEnabled(false);
@@ -427 +418 @@
     }
 
-    static private class HeaderPanel extends JPanel {
+    private static class HeaderPanel extends JPanel {
 
         private JMultilineLabel lblMessage;
         private Changeset current;
 
-        protected void build() {
+        protected final void build() {
             setLayout(new FlowLayout(FlowLayout.LEFT));
             lblMessage = new JMultilineLabel(
@@ -455 +446 @@
                 putValue(NAME, tr("Download now"));
                 putValue(SHORT_DESCRIPTION, tr("Download the changeset content"));
-                putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset", "downloadchangesetcontent"));
+                putValue(SMALL_ICON, ChangesetCacheManager.DOWNLOAD_CONTENT_ICON);
             }
 

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/ChangesetDetailPanel.java

@@ -42 +42 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 
-
 /**
  * This panel displays the properties of the currently selected changeset in the
@@ -48 +47 @@
  *
  */
-public class ChangesetDetailPanel extends JPanel implements PropertyChangeListener{
-
-    private JosmTextField tfID;
-    private JosmTextArea taComment;
-    private JosmTextField tfOpen;
-    private JosmTextField tfUser;
-    private JosmTextField tfCreatedOn;
-    private JosmTextField tfClosedOn;
-    private DonwloadChangesetContentAction actDownloadChangesetContent;
-    private UpdateChangesetAction actUpdateChangesets;
-    private RemoveFromCacheAction actRemoveFromCache;
-    private SelectInCurrentLayerAction actSelectInCurrentLayer;
-    private ZoomInCurrentLayerAction actZoomInCurrentLayerAction;
+public class ChangesetDetailPanel extends JPanel implements PropertyChangeListener {
+
+    private final JosmTextField tfID        = new JosmTextField(10);
+    private final JosmTextArea  taComment   = new JosmTextArea(5,40);
+    private final JosmTextField tfOpen      = new JosmTextField(10);
+    private final JosmTextField tfUser      = new JosmTextField("");
+    private final JosmTextField tfCreatedOn = new JosmTextField(20);
+    private final JosmTextField tfClosedOn  = new JosmTextField(20);
+
+    private final DownloadChangesetContentAction actDownloadChangesetContent = new DownloadChangesetContentAction();
+    private final UpdateChangesetAction          actUpdateChangesets         = new UpdateChangesetAction();
+    private final RemoveFromCacheAction          actRemoveFromCache          = new RemoveFromCacheAction();
+    private final SelectInCurrentLayerAction     actSelectInCurrentLayer     = new SelectInCurrentLayerAction();
+    private final ZoomInCurrentLayerAction       actZoomInCurrentLayerAction = new ZoomInCurrentLayerAction();
 
     private Changeset current = null;
@@ -71 +71 @@
 
         // -- remove from cache action
-        tb.add(actRemoveFromCache = new RemoveFromCacheAction());
+        tb.add(actRemoveFromCache);
         actRemoveFromCache.initProperties(current);
 
         // -- changeset update
-        tb.add(actUpdateChangesets = new UpdateChangesetAction());
+        tb.add(actUpdateChangesets);
         actUpdateChangesets.initProperties(current);
 
         // -- changeset content download
-        tb.add(actDownloadChangesetContent =new DonwloadChangesetContentAction());
+        tb.add(actDownloadChangesetContent);
         actDownloadChangesetContent.initProperties(current);
 
-        tb.add(actSelectInCurrentLayer = new SelectInCurrentLayerAction());
+        tb.add(actSelectInCurrentLayer);
         MapView.addEditLayerChangeListener(actSelectInCurrentLayer);
 
-        tb.add(actZoomInCurrentLayerAction = new ZoomInCurrentLayerAction());
+        tb.add(actZoomInCurrentLayerAction);
         MapView.addEditLayerChangeListener(actZoomInCurrentLayerAction);
 
@@ -119 +119 @@
         gc.weightx = 0.0;
         gc.gridx = 1;
-        pnl.add(tfID = new JosmTextField(10), gc);
+        pnl.add(tfID, gc);
         tfID.setEditable(false);
 
@@ -133 +133 @@
         gc.weighty = 1.0;
         gc.gridx = 1;
-        pnl.add(taComment= new JosmTextArea(5,40), gc);
+        pnl.add(taComment, gc);
         taComment.setEditable(false);
 
@@ -146 +146 @@
         gc.fill = GridBagConstraints.HORIZONTAL;
         gc.gridx = 1;
-        pnl.add(tfOpen= new JosmTextField(10), gc);
+        pnl.add(tfOpen, gc);
         tfOpen.setEditable(false);
 
@@ -159 +159 @@
         gc.weightx = 1.0;
         gc.gridx = 1;
-        pnl.add(tfUser= new JosmTextField(""), gc);
+        pnl.add(tfUser, gc);
         tfUser.setEditable(false);
 
@@ -171 +171 @@
         gc.fill = GridBagConstraints.HORIZONTAL;
         gc.gridx = 1;
-        pnl.add(tfCreatedOn= new JosmTextField(20), gc);
+        pnl.add(tfCreatedOn, gc);
         tfCreatedOn.setEditable(false);
 
@@ -183 +183 @@
         gc.fill = GridBagConstraints.HORIZONTAL;
         gc.gridx = 1;
-        pnl.add(tfClosedOn= new JosmTextField(20), gc);
+        pnl.add(tfClosedOn, gc);
         tfClosedOn.setEditable(false);
 
@@ -189 +189 @@
     }
 
-    protected void build() {
+    protected final void build() {
         setLayout(new BorderLayout());
         setBorder(BorderFactory.createEmptyBorder(3,3,3,3));
@@ -259 +259 @@
         if (! evt.getPropertyName().equals(ChangesetCacheManagerModel.CHANGESET_IN_DETAIL_VIEW_PROP))
             return;
-        Changeset cs = (Changeset)evt.getNewValue();
-        setCurrentChangeset(cs);
+        setCurrentChangeset((Changeset)evt.getNewValue());
     }
 
@@ -289 +288 @@
      *
      */
-    class DonwloadChangesetContentAction extends AbstractAction{
-        public DonwloadChangesetContentAction() {
+    class DownloadChangesetContentAction extends AbstractAction {
+        public DownloadChangesetContentAction() {
             putValue(NAME, tr("Download content"));
-            putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset","downloadchangesetcontent"));
+            putValue(SMALL_ICON, ChangesetCacheManager.DOWNLOAD_CONTENT_ICON);
             putValue(SHORT_DESCRIPTION, tr("Download the changeset content from the OSM server"));
         }
@@ -299 +298 @@
         public void actionPerformed(ActionEvent evt) {
             if (current == null) return;
-            ChangesetContentDownloadTask task = new ChangesetContentDownloadTask(ChangesetDetailPanel.this,current.getId());
+            ChangesetContentDownloadTask task = new ChangesetContentDownloadTask(ChangesetDetailPanel.this, current.getId());
             ChangesetCacheManager.getInstance().runDownloadTask(task);
         }
@@ -312 +311 @@
             if (cs.getContent() == null) {
                 putValue(NAME, tr("Download content"));
-                putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset","downloadchangesetcontent"));
+                putValue(SMALL_ICON, ChangesetCacheManager.DOWNLOAD_CONTENT_ICON);
                 putValue(SHORT_DESCRIPTION, tr("Download the changeset content from the OSM server"));
             } else {
                 putValue(NAME, tr("Update content"));
-                putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset","updatechangesetcontent"));
+                putValue(SMALL_ICON, ChangesetCacheManager.UPDATE_CONTENT_ICON);
                 putValue(SHORT_DESCRIPTION, tr("Update the changeset content from the OSM server"));
             }
@@ -329 +328 @@
         public UpdateChangesetAction() {
             putValue(NAME, tr("Update changeset"));
-            putValue(SMALL_ICON,ImageProvider.get("dialogs/changeset","updatechangeset"));
+            putValue(SMALL_ICON, ChangesetCacheManager.UPDATE_CONTENT_ICON);
             putValue(SHORT_DESCRIPTION, tr("Update the changeset from the OSM server"));
         }

trunk/src/org/openstreetmap/josm/gui/dialogs/changeset/SingleChangesetDownloadPanel.java

@@ -20 +20 @@
 import org.openstreetmap.josm.gui.widgets.ChangesetIdTextField;
 import org.openstreetmap.josm.gui.widgets.SelectAllOnFocusGainedDecorator;
-import org.openstreetmap.josm.tools.ImageProvider;
 
 /**
@@ -80 +79 @@
 
         public DownloadAction() {
-            putValue(SMALL_ICON, ImageProvider.get("dialogs/changeset", "downloadchangesetcontent"));
+            putValue(SMALL_ICON, ChangesetCacheManager.DOWNLOAD_CONTENT_ICON);
             putValue(SHORT_DESCRIPTION, tr("Download the changeset with the specified id, including the changeset content"));
             updateEnabledState();

trunk/src/org/openstreetmap/josm/gui/mappaint/LabelCompositionStrategy.java

@@ -153 +153 @@
          * The list of default name tags from which a label candidate is derived.
          */
-        static public final String[] DEFAULT_NAME_TAGS = {
+        public static final String[] DEFAULT_NAME_TAGS = {
             "name:" + LanguageInfo.getJOSMLocaleCode(),
             "name",
@@ -167 +167 @@
          * @since 6541
          */
-        static public final String[] DEFAULT_NAME_COMPLEMENT_TAGS = {
+        public static final String[] DEFAULT_NAME_COMPLEMENT_TAGS = {
             "capacity"
         };

trunk/src/org/openstreetmap/josm/gui/preferences/advanced/PreferencesTable.java

@@ -12 +12 @@
 import java.awt.event.MouseEvent;
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.List;
 import java.util.Map;
@@ -120 +119 @@
             if (llEditor.getValue() == 1) {
                 List<List<String>> data = llEditor.getData();
-                @SuppressWarnings("unchecked")
-                Collection<Collection<String>> stgValue = (Collection<Collection<String>>) stg.getValue();
                 if (!llSetting.equalVal(data)) {
                     e.setValue(new Preferences.ListListSetting(data));

trunk/src/org/openstreetmap/josm/gui/preferences/plugin/PluginPreference.java

@@ -55 +55 @@
 import org.openstreetmap.josm.tools.ImageProvider;
 
+/**
+ * Preference settings for plugins.
+ * @since 168
+ */
 public final class PluginPreference extends DefaultTabPreferenceSetting {
 
@@ -71 +75 @@
     }
 
+    /**
+     * Returns the download summary string to be shown.
+     * @param task The plugin download task that has completed
+     * @return the download summary string to be shown. Contains summary of success/failed plugins.
+     */
     public static String buildDownloadSummary(PluginDownloadTask task) {
         Collection<PluginInformation> downloaded = task.getDownloadedPlugins();
@@ -469 +478 @@
     }
 
-    static private class PluginConfigurationSitesPanel extends JPanel {
+    private static class PluginConfigurationSitesPanel extends JPanel {
 
         private DefaultListModel model;

trunk/src/org/openstreetmap/josm/gui/widgets/EditableList.java

@@ -32 +32 @@
     public final JButton deleteSrcButton = new JButton(tr("Delete"));
 
+    /**
+     * Constructs a new {@code EditableList}.
+     * @param title The title displayed in input dialog
+     */
     public EditableList(String title) {
         this.title = title;
@@ -37 +41 @@
     }
 
-    protected void build() {
+    protected final void build() {
 
-        //setLayout(new GridBagLayout());
         setLayout(new BorderLayout());