Context Navigation

josm

Timestamp:

2013-11-05T23:12:52+01:00 (10 years ago)

Author:

Don-vip

Message:

Sonar/Findbugs - unused code

Location:

trunk/src/org/openstreetmap/josm

Files:

-              r6336
+              r6367
     /**
-     * This method filters the list of relations that form the multipolygons.
-     * @param relations all relations
-     * @param polygons polygons for filtering
-     * @return relations which don't form the polygons
-     */
-    private List<Relation> filterOwnMultipolygonRelations(Collection<Relation> relations, List<Multipolygon> polygons) {
-        List<Relation> relationsToRemove = new ArrayList<Relation>();
-        for (Multipolygon m : polygons) {
-            if (m.relation != null) {
-                relationsToRemove.add(m.relation);
+            }
+        }
-        List<Relation> result = new ArrayList<Relation>();
-        result.addAll(relations);
-        result.removeAll(relationsToRemove);
-        return result;
+    }
-    /**
      * Will add own multipolygon relation to the "previously existing" relations. Fixup is done by fixRelations
      * @param inner List of already closed inner ways

-              r6316
+              r6367
+    }
-    private boolean isValidModifierCombination() {
-        // TODO: implement to give feedback on invalid modifier combination
-        return true;
+    }
     private boolean sanityCheck() {
         // @formatter:off

-              r6317
+              r6367
+    }
-    synchronized private Map<String, String> getAllPrefixDefault(final String prefix) {
-        final Map<String,String> all = new TreeMap<String,String>();
-        for (final Entry<String,String> e : defaults.entrySet()) {
-            if (e.getKey().startsWith(prefix)) {
-                all.put(e.getKey(), e.getValue());
+            }
+        }
-        return all;
+    }
     synchronized public Map<String, String> getAllColors() {
         final Map<String,String> all = new TreeMap<String,String>();

-              r6316
+              r6367
+    }
-    private String getLeadingNumber(String s) {
-        int i = 0;
-        while (i < s.length() && Character.isDigit(s.charAt(i))) {
-            i++;
+        }
-        return s.substring(0, i);
+    }
     private String getRelationTypeName(IRelation relation) {
         String name = trc("Relation type", relation.get("type"));

-              r6246
+              r6367
+    }
+    private void setup(String name, String property, String tooltip, ActionListener actionListener)
+    {
+        doStyle();
+        setActionCommand(name);
+        addActionListener(actionListener);
+        setToolTipText(tooltip);
+        putClientProperty("help", "Dialog/"+property+"/"+name);
+    }
+    private void doStyle()
+    {
+    private void doStyle() {
         setLayout(new BorderLayout());
         setIconTextGap(2);

-              r6362
+              r6367
         private PreferenceScrollPane(PreferencePanel preferencePanel) {
+            super(preferencePanel.getComponent());
+            this.preferenceSetting = preferencePanel.getTabPreferenceSetting();
+            this(preferencePanel.getComponent(), preferencePanel.getTabPreferenceSetting());
+        }

-              r6362
+              r6367
     private String shortText;        // the unique ID of the shortcut
     private String longText;         // a human readable description that will be shown in the preferences
     private int requestedKey;        // the key, the caller requested
     private int requestedGroup;      // the group, the caller requested
+    private final int requestedKey;  // the key, the caller requested
+    private final int requestedGroup;// the group, the caller requested
     private int assignedKey;         // the key that actually is used
     private int assignedModifier;    // the modifiers that are used
 …
     private void setLongText(String longText) {
         this.longText = longText;
+    }
-    private int getRequestedKey() {
-        return requestedKey;
+    }
-    public int getRequestedGroup() {
-        return requestedGroup;
+    }

Note: See TracChangeset for help on using the changeset viewer.